Age | Commit message (Collapse) | Author |
|
Summary: kdebugsettings categories files
Reviewers: dfaure, cgiboudeaux
Reviewed By: cgiboudeaux
Subscribers: kossebau, kde-frameworks-devel, kde-buildsystem
Tags: #frameworks, #build_system
Differential Revision: https://phabricator.kde.org/D21313
|
|
Summary:
Strict iterators can't be used on Windows, they lead to a link error
when application code iterates over a QVector<QPoint> for instance, unless
Qt itself was also built with strict iterators.
See example at https://bugreports.qt.io/browse/AUTOSUITE-946
Technically this would be fine for mingw, but not for MSVC neither
clang-cl (which also uses the MSVC ABI). I think it's fine to just
disable it for all Windows compilers, since any iterators misuse
will be detected on Unix anyway.
Test Plan: None, I'm relying on Volker's findings.
Reviewers: vkrause, dvratil
Reviewed By: dvratil
Subscribers: apol, kde-frameworks-devel, kde-buildsystem
Tags: #frameworks, #build_system
Differential Revision: https://phabricator.kde.org/D21314
|
|
|
|
Summary:
Find C++ shared lib path using regex. This change makes finding path
independent of the order in which it was added by cmake.
Reviewers: apol
Reviewed By: apol
Subscribers: kde-buildsystem, kde-frameworks-devel
Tags: #frameworks, #build_system
Differential Revision: https://phabricator.kde.org/D20558
|
|
Summary:
Don't include same dependency twice, one which was found
from `readelf` in `specifydependencies.cmake` and other in
`ANDROID_EXTRA_LIBS`.
Bug fix: find stl was dependent on the order in which libc++
was added, now it is independent.
Test Plan: * add the same dependency in ANDROID_EXTRA_LIBS
Reviewers: apol, vkrause
Reviewed By: apol
Subscribers: kde-buildsystem, kde-frameworks-devel
Tags: #frameworks, #build_system
Differential Revision: https://phabricator.kde.org/D20509
|
|
|
|
Summary:
It turns out QT_STRICT_ITERATORS does not introduce any
overhead (they are inlined so everything gets optimized), confirmed by
Dan comparing the produced assembly in Compiler Explorer.
Reviewers: dvratil, mlaurent, aacid
Reviewed By: aacid
Subscribers: aacid, kde-buildsystem, kde-frameworks-devel
Tags: #frameworks, #build_system
Differential Revision: https://phabricator.kde.org/D20349
|
|
Let's see if purpose unittests still work on Windows (which was the
reason this got commented out, kio_file wasn't found anymore).
CCMAIL: bcooksley@kde.org, kfunk@kde.org
|
|
Summary: Instead of passing the data from stdin, pass the path, this way if there's an error wayland-scanner will be able to tell us the file and line where it's failing.
Test Plan: Built kwayland and kwin with it
Reviewers: #kwin, #frameworks, zzag
Reviewed By: #kwin, zzag
Subscribers: kde-frameworks-devel, kde-buildsystem
Tags: #frameworks, #build_system
Differential Revision: https://phabricator.kde.org/D20105
|
|
This reverts commit 2e1cb0c453f419da134b850052da6c804cae05e0.
This was an accidental push to master, sorry for the noise.
|
|
|
|
|
|
Summary:
Note that the first test had a comment "without optional arguments"
so I removed the INCLUDE_INSTALL_DIR variable to test what happens by
default. The other tests still pass an absolute path there (which is
unusual in practice, and breaks the idea of using ${prefix}).
Test Plan: `ctest -R PkgConfig` passes
Reviewers: kossebau, apol, cgiboudeaux
Reviewed By: apol
Subscribers: kde-frameworks-devel, kde-buildsystem, fazevedo
Tags: #frameworks, #build_system
Differential Revision: https://phabricator.kde.org/D19538
|
|
Summary:
This one is originally coming from Solid, but there are several more copies
in our repositories (plasma-desktop, kwin, powerdevil, etc).
Reviewers: cgiboudeaux
Reviewed By: cgiboudeaux
Subscribers: cgiboudeaux, kde-frameworks-devel, kde-buildsystem
Tags: #frameworks, #build_system
Differential Revision: https://phabricator.kde.org/D19486
|
|
GIT_SILENT
|
|
|
|
Summary:
If we ever end up in a situation where the generated .pc file is
actually used by cmake's pkg_check_modules, then we need the
includedir and libdir variables; pkg_check_modules ignores the
Makefile-like Libs and Cflags lines of the .pc file.
Context: craft adds a cmake buildsystem for sqlite3, which is then
found using pkgconfig in akonadi.
Test Plan: Filipe Azevedo is doing all the testing, I'm just providing patches :)
Reviewers: apol, fazevedo, cgiboudeaux
Reviewed By: fazevedo, cgiboudeaux
Subscribers: cgiboudeaux, fazevedo, kde-buildsystem, kde-frameworks-devel
Tags: #frameworks, #build_system
Differential Revision: https://phabricator.kde.org/D19506
|
|
Summary:
I don't understand where plasma-desktop actually finds that old find
module, but this fixes the build at least.
Reviewers: cgiboudeaux
Reviewed By: cgiboudeaux
Subscribers: kde-frameworks-devel, kde-buildsystem
Tags: #frameworks, #build_system
Differential Revision: https://phabricator.kde.org/D19499
|
|
|
|
Summary: Originally coming from KWin, but now also needed by qtbase.
Reviewers: cgiboudeaux
Reviewed By: cgiboudeaux
Subscribers: kossebau, apol, cgiboudeaux, kde-frameworks-devel, kde-buildsystem
Tags: #frameworks, #build_system
Differential Revision: https://phabricator.kde.org/D18943
|
|
|
|
Summary: This fixes the Marble build on binary factory.
Reviewers: apol
Reviewed By: apol
Subscribers: kde-frameworks-devel, kde-buildsystem
Tags: #frameworks, #build_system
Differential Revision: https://phabricator.kde.org/D19223
|
|
|
|
Summary:
${EGL_INCLUDE_DIR} is the path up to 'egl.h' -- so the header is
${EGL_INCLUDE_DIR}/egl.h
The compile test on the other hand includes 'EGL/egl.h', so the path
that needs to be passed to the compile test is "${EGL_INCLUDE_DIR}/..".
Reviewers: #automotive, hausmann, #freebsd, apol
Reviewed By: #automotive, hausmann, apol
Subscribers: bcooksley, kde-frameworks-devel, kde-buildsystem
Tags: #frameworks, #build_system
Differential Revision: https://phabricator.kde.org/D19075
|
|
Summary:
used by:
- knotification
- (possibly also knotifyconfig at some point)
- plasma-pa
- kmix
Reviewers: cgiboudeaux
Reviewed By: cgiboudeaux
Subscribers: aacid, apol, kde-frameworks-devel, kde-buildsystem
Tags: #frameworks, #build_system
Differential Revision: https://phabricator.kde.org/D18952
|
|
Summary:
- NDK r18 does not ship GCC anymore, it's only clang now
- same for STL, there's only libc++ there
- API level 14 is not supported either anymore, the minimum supported by
the current NDK is 16
- The minimum supported API level by KF5 right now is 21 though, so use
that as the default
Reviewers: apol
Reviewed By: apol
Subscribers: apol, kde-frameworks-devel, kde-buildsystem
Tags: #frameworks, #build_system
Differential Revision: https://phabricator.kde.org/D19016
|
|
Perform additional sanity checking by doing a compile test.
Differential Revision: https://phabricator.kde.org/D18960
|
|
Summary: Also place "Since" next to both argument and argument description.
Reviewers: cgiboudeaux
Reviewed By: cgiboudeaux
Subscribers: kde-frameworks-devel, kde-buildsystem
Tags: #frameworks, #build_system
Differential Revision: https://phabricator.kde.org/D18913
|
|
|
|
|
|
Summary:
clazy 1.5 renamed its plugin from from `ClangLazy.so` to
`ClazyPlugin.so` and from `clang-lazy` to `clazy`.
Reviewers: apol, smartins
Subscribers: kde-frameworks-devel, kde-buildsystem
Tags: #frameworks, #build_system
Differential Revision: https://phabricator.kde.org/D18680
|
|
|
|
Summary:
Avoids to have manually set the property on the generated source file to
deal with changed CMake policy CMP0071.
Reviewers: #frameworks, pino, apol
Reviewed By: apol
Subscribers: kde-frameworks-devel, kde-buildsystem
Tags: #frameworks, #build_system
Differential Revision: https://phabricator.kde.org/D18088
|
|
Summary: They really help making the code better so it's good to have all applications getting those warnings
Subscribers: apol, vkrause, kde-frameworks-devel, kde-buildsystem
Tags: #frameworks, #build_system
Differential Revision: https://phabricator.kde.org/D18167
|
|
Test Plan: kcoreaddons compiles again
Reviewers: lbeltrame
Reviewed By: lbeltrame
Subscribers: cgiboudeaux, skelly, kde-frameworks-devel, kde-buildsystem
Tags: #frameworks, #build_system
Differential Revision: https://phabricator.kde.org/D18345
|
|
Summary:
Patch by Eike Ziller from https://github.com/KDAB/GammaRay/pull/526 in
response to Qt change https://codereview.qt-project.org/#/c/248684/.
Reviewers: apol
Reviewed By: apol
Subscribers: kde-frameworks-devel, kde-buildsystem
Tags: #frameworks, #build_system
Differential Revision: https://phabricator.kde.org/D18243
|
|
|
|
|
|
|
|
|
|
|
|
|
|
This reverts commit e1adaa7ebab1b0de72c82d95bdf568e435713a4e.
Version number confusion.
|
|
Summary:
The clang compiler in Android NDK r15b, which has version 5.0.300080,
warns as follows:
warning: unknown warning option '-Wzero-as-null-pointer-constant'; did you mean '-Wint-to-void-pointer-cast'? [-Wunknown-warning-option]
Test Plan: Removing the option removes the warning
Reviewers: aacid, cgiboudeaux, apol
Reviewed By: cgiboudeaux
Subscribers: kde-frameworks-devel, kde-buildsystem
Tags: #frameworks, #build_system
Differential Revision: https://phabricator.kde.org/D17714
|
|
|
|
Summary:
This is currently in use by plasma-phone-components, but will also be
needed by KItinerary.
Reviewers: #build_system, #frameworks, cgiboudeaux
Reviewed By: cgiboudeaux
Subscribers: cgiboudeaux, kde-frameworks-devel, kde-buildsystem
Tags: #frameworks, #build_system
Differential Revision: https://phabricator.kde.org/D16954
|
|
New users can use this module instead of adding a copy of the old FindExiv2.cmake module.
|
|
According to lxr, we have 8 copies of this module in different repositories (+kdelib4support and a playground repo).
|
|
Summary:
Infer the toolchain we are using through cmake's detection of ranlib
instead of asking the user to fill it.
It's only used in androiddeployqt and cmake expects it to be version
"clang" for clang builds while androiddeployqt expects it to be "4.9".
Reviewers: #build_system, #android, vkrause
Reviewed By: #android, vkrause
Subscribers: kde-frameworks-devel, kde-buildsystem
Tags: #frameworks, #build_system
Differential Revision: https://phabricator.kde.org/D16930
|
|
Summary:
The Qt5Help CMake modules contain the Qt5::qhelpgenerator target, so
look for that instead of Qt5Core. Otherwise, the Qt5::qhelpgenerator
is available only if Qt5Help was searched previously (which does not
happen often).
Using the Qt5::qhelpgenerator is more reliable than the search for the
qhelpgenerator executable based on the qmake path.
Test Plan:
build some framework with -DBUILD_QCH=ON, and notice that
the right path of qhelpgenerator is found directly with the
Qt5::qhelpgenerator target.
Reviewers: kossebau
Reviewed By: kossebau
Subscribers: kde-frameworks-devel, kde-buildsystem
Tags: #frameworks, #build_system
Differential Revision: https://phabricator.kde.org/D16938
|