Age | Commit message (Collapse) | Author |
|
|
|
Summary: Just default to whichever is installed
Test Plan: Built kalgebra
Reviewers: #frameworks, vkrause
Reviewed By: vkrause
Subscribers: alexeymin, kde-frameworks-devel, kde-buildsystem
Tags: #frameworks, #build_system
Differential Revision: https://phabricator.kde.org/D14544
|
|
Subscribers: kde-frameworks-devel, kde-buildsystem
Tags: #frameworks, #build_system
Differential Revision: https://phabricator.kde.org/D14541
|
|
Summary:
We'd check if the variable's value is defined, which is wrong and prevented us
from properly initialising using these deprecated variables.
It would also ignore the value we're passing to the actually right variable when
using it.
Test Plan: Built kstars which needs -DCMAKE_ANDROID_API=24
Reviewers: #frameworks, vkrause
Reviewed By: vkrause
Subscribers: kde-frameworks-devel, kde-buildsystem
Tags: #frameworks, #build_system
Differential Revision: https://phabricator.kde.org/D14187
|
|
These changes are not available in ECM 5.48.0.
|
|
Summary:
- Add support for SIDEBAR_ICONS on macOS
- Allow specifying a basename for the icon file via OUTFILE_BASENAME
- Add support for HiRes icons on Windows via icotool
I'm sorry this went all into one big change. I see that it's not optimal,
but it's really hard to rip it apart...
Also to me the whole code with support for two flavors of png2ico and icotool seems very spaghetti-ish. IMHO there's no good reason to keep supporting all three, icotool is the only maintained project and the only one supporting more than 128px wide icons. That's why I would suggest to simplify the whole code by only supporting icotool in one of the next releases.
Test Plan:
We use this version of ECMAddAppIconMacro in ownCloud client and it works...
I tested icotool natively and while cross-compiling on linux.
SIDEBAR_ICONS are also working...
If you want to test this with the ownCloud client, it's best to use
https://github.com/dschmidt/owncloud-client/tree/fix-app-icon-macro
because that contains a small fix I just PR'ed and which is not
in master yet. (We maintain a fork of the module there, so compiling it for Windows or macOS will automatically use the version of the module that I'm submitting)
Reviewers: vonreth, vpinon, apol, alexmerry, cgiboudeaux
Reviewed By: cgiboudeaux
Subscribers: cgiboudeaux, kde-frameworks-devel, kde-buildsystem
Tags: #frameworks, #build_system
Differential Revision: https://phabricator.kde.org/D13698
|
|
Summary:
Some projects such as marble do some operations with the APK directory
before building. This allows us the project to copy the apk directory
over to the build directory and do whatever it pleases.
Test Plan: Built Marble
Reviewers: #frameworks, vkrause
Reviewed By: vkrause
Subscribers: vkrause, kde-frameworks-devel, kde-buildsystem
Tags: #frameworks, #build_system
Differential Revision: https://phabricator.kde.org/D13403
|
|
Summary:
QT_USE_FAST_OPERATOR_PLUS has been deprecated in Qt 4.8, in favour of
QT_USE_QSTRINGBUILDER. The latter also covers QByteArray.
Qt5 headers still supports QT_USE_FAST_OPERATOR_PLUS (at least 5.11.1),
as subset of QT_USE_QSTRINGBUILDER as it was introduced in Qt4.8,
but not as documented build flag.
Given QT_USE_QSTRINGBUILDER is set here and thus triggers anything that
QT_USE_FAST_OPERATOR_PLUS would trigger in Qt code, removing it should
clean up the macro from undocumented features and thus reduce confusion.
No non-Qt is known at least in KDE repos which checks this build flag
otherwise, so no regression should be expected here as well.
Reviewers: vkrause
Reviewed By: vkrause
Subscribers: kde-frameworks-devel, kde-buildsystem
Tags: #frameworks, #build_system
Differential Revision: https://phabricator.kde.org/D13800
|
|
Reviewers: cgiboudeaux, apol
Reviewed By: cgiboudeaux, apol
Subscribers: apol, kde-frameworks-devel, kde-buildsystem, cgiboudeaux, dhaumann
Tags: #frameworks, #build_system
Differential Revision: https://phabricator.kde.org/D10166
|
|
Summary:
Quite some C++-based projects do not use .h as header file extension, but
.hpp, .hxx or other variants. Making the header file extension configurable
enables to make use of ECMGenerateHeaders in such projects.
Test Plan:
The added unit test works, existing unit tests work as before.
Also using in project with .hpp files works.
Reviewers: apol
Reviewed By: apol
Subscribers: apol, kde-frameworks-devel, kde-buildsystem
Tags: #frameworks, #build_system
Differential Revision: https://phabricator.kde.org/D13721
|
|
|
|
Summary:
It's not a thing on flatpak and it makes packaging weird.
Should fix https://github.com/flatpak/freedesktop-sdk-base/issues/22
Reviewers: #frameworks, cgiboudeaux
Reviewed By: cgiboudeaux
Subscribers: cgiboudeaux, eszlari, kde-frameworks-devel, kde-buildsystem
Tags: #frameworks, #build_system
Differential Revision: https://phabricator.kde.org/D13102
|
|
|
|
Summary: Add new variable ANDROID_EXTRA_LIBS, which can contain list of full paths to libs to include in resulting APK file. This can be used to include plugins that are not directly liked to executable, for example OpenSSL libs for QtNetwork SSL/HTTPS support.
Test Plan: Build project with -DANDROID_EXTRA_LIBS="/path/to/lib.so;/path/to/other_lib.so". Build without it. In both cases verify APK contents.
Reviewers: apol
Reviewed By: apol
Subscribers: kde-buildsystem, kde-frameworks-devel
Tags: #frameworks, #build_system
Differential Revision: https://phabricator.kde.org/D13198
|
|
|
|
Otherwise androiddeployqt fails like it's failing now for kirigami
https://binary-factory.kde.org/view/Android/job/KirigamiGallery_android/48/console
|
|
Summary:
These typos show up in the generated manpages.
Reviewers: #frameworks, alexmerry, kossebau, cgiboudeaux
Reviewed By: cgiboudeaux
Subscribers: cgiboudeaux, kde-frameworks-devel, kde-buildsystem
Tags: #frameworks, #build_system
Differential Revision: https://phabricator.kde.org/D12867
|
|
|
|
|
|
|
|
Use the variable we just created to look up Qt5.
Remove debug warning.
|
|
Summary:
Otherwise we hit a weird code path on androiddeployqt. This is what the official SDK looks like anyway:
```
$ ls /opt/Qt/5.10.1/android_armv7/
bin doc include jar lib mkspecs plugins qml src translations
```
Reviewers: vkrause
Reviewed By: vkrause
Subscribers: #frameworks, #build_system
Tags: #frameworks, #build_system
Differential Revision: https://phabricator.kde.org/D12269
|
|
|
|
Summary:
Refactor the apk-generating code into a separate function, in views of
eventually even make it a module.
It also changes so that if no APK dir is specified, a generic dummy one is
used. Useful for proofs of concept.
Test Plan: Built kate, got kate and kwrite apks
Reviewers: #frameworks, #build_system, vkrause
Reviewed By: vkrause
Subscribers: vkrause
Tags: #frameworks, #build_system
Differential Revision: https://phabricator.kde.org/D12150
|
|
Summary:
Back in the KDE Edu sprint, we decided we need such a check, otherwise
you get rather frustrated when the application isn't started. A patch to
androiddeployqt was submitted but rejected by the maintainer.
https://codereview.qt-project.org/#/c/207941/
Test Plan: kate doesn't build if we don't pass Q_DECL_EXPORT, builds if we do.
Reviewers: #frameworks, #build_system, vkrause
Reviewed By: vkrause
Subscribers: vkrause, vatra, aacid
Tags: #frameworks, #build_system
Differential Revision: https://phabricator.kde.org/D12120
|
|
concepts
Summary: Mark as deprecated the redundant variables and focus on the difference.
Reviewers: #build_system, #frameworks, vkrause
Reviewed By: vkrause
Subscribers: vkrause
Tags: #frameworks, #build_system
Differential Revision: https://phabricator.kde.org/D11984
|
|
Summary:
Instead of having ad-hoc code for gcc, let CMake do its thing. It has a lot of
logic that we may be interested in, for example it will make the clang switch
much smoother.
Note it raises the minimum cmake to 3.7 for Android, which was released almost
2 years ago.
Test Plan: Built kalgebra on it using kdeorg/android-sdk
Reviewers: #frameworks, #build_system, vkrause
Reviewed By: vkrause
Subscribers: vkrause
Tags: #frameworks, #build_system
Differential Revision: https://phabricator.kde.org/D11776
|
|
|
|
Summary:
This macro helps with setting up all the boilerplate CMake code needed
to instruct automoc about the custom C++ macros used to define Qt-style
plugin class instances.
Reviewers: #build_system, #frameworks, apol
Reviewed By: apol
Subscribers: apol
Tags: #frameworks, #build_system
Differential Revision: https://phabricator.kde.org/D10749
|
|
Summary:
This is needed for a new feature in Qt 5.12, making androiddepolyqt's
recursive dependency resolution avaiable for components installed in
different prefixes too.
This will allow us to drop our own partial ELF dependency parsing code
eventually, as well as avoid having to do workarounds like linking against
all indirect dependencies.
Reviewers: #build_system, apol
Reviewed By: apol
Subscribers: #frameworks
Tags: #frameworks, #build_system
Differential Revision: https://phabricator.kde.org/D11388
|
|
Summary: qmake also generates it and androiddeployqt consumes it.
Test Plan: built and ran kalgebra
Reviewers: #frameworks, vkrause
Reviewed By: vkrause
Subscribers: vkrause, #build_system
Tags: #frameworks, #build_system
Differential Revision: https://phabricator.kde.org/D11342
|
|
Summary: qmlimportscanner fails when provided symlinks, so work around that.
Reviewers: #build_system, apol
Reviewed By: apol
Subscribers: #frameworks
Tags: #frameworks, #build_system
Differential Revision: https://phabricator.kde.org/D11181
|
|
|
|
Summary:
This makes the qmlimportscanner find our QML files and plugins correctly.
That's IMHO much cleaner than the full copy of everything in the lib/qml
folder we do via the android-extra-plugins list.
Reviewers: #build_system, apol
Reviewed By: apol
Subscribers: #frameworks
Tags: #frameworks, #build_system
Differential Revision: https://phabricator.kde.org/D11177
|
|
|
|
Summary:
This is needed for NDK headers to work correctly, and is the same as the
CMake code in the NDK does.
Reviewers: #build_system, apol
Reviewed By: apol
Subscribers: apol, #frameworks
Tags: #frameworks, #build_system
Differential Revision: https://phabricator.kde.org/D10777
|
|
Summary:
The prefix for the command is i686-linux-android, while the toolchain is
x86 in this case. On ARM both values are the same.
Reviewers: #build_system, apol
Reviewed By: apol
Subscribers: #frameworks
Tags: #frameworks, #build_system
Differential Revision: https://phabricator.kde.org/D10625
|
|
Summary:
Those affect policy propagation and search path order for relative
includes in CMake code, none of which is needed here. This silences
a ton of warnings with CMake 3.10.
Reviewers: #build_system, apol
Reviewed By: apol
Subscribers: #frameworks
Tags: #frameworks, #build_system
Differential Revision: https://phabricator.kde.org/D10602
|
|
Summary: This allows e.g. KArchive to find zlib correctly.
Reviewers: #build_system, apol
Reviewed By: apol
Subscribers: #frameworks
Tags: #frameworks, #build_system
Differential Revision: https://phabricator.kde.org/D10601
|
|
Summary:
This allows easy platforms checks in CMake files, and is the same the
CMake files shipped by the Android SDK use.
Reviewers: #build_system, apol
Reviewed By: apol
Subscribers: #frameworks
Tags: #frameworks, #build_system
Differential Revision: https://phabricator.kde.org/D10600
|
|
Summary:
ANDROID_TOOLCHAIN is "x86" there, while the include path we want is
"i686-linux-android". ANDROID_COMPILER_PREFIX has that value in all
cases (for ARM both are the same, so nothing changes there).
Reviewers: #build_system, apol
Reviewed By: apol
Subscribers: apol, dfaure, #frameworks
Tags: #frameworks, #build_system
Differential Revision: https://phabricator.kde.org/D10599
|
|
Summary:
For ARM it's not necessary, but when building for a x86 tablet I had to
set ANDROID_TOOLCHAIN=x86 while gcc/g++ are prefixed with
i686-linux-android.
i.e. the path is android-ndk-r10e/toolchains/x86-4.9/prebuilt/linux-x86_64/bin/i686-linux-android-g++
Test Plan: cmake picks up the right compiler for me now
Reviewers: apol, mart
Reviewed By: apol
Subscribers: #build_system, #frameworks
Tags: #frameworks, #build_system
Differential Revision: https://phabricator.kde.org/D10462
|
|
|
|
Summary: Instead of hardcoded /usr/lib, same solution as in D9116
Test Plan: Works fine with kwayland 5.42.0.
Reviewers: #frameworks, #build_system, cgiboudeaux
Reviewed By: cgiboudeaux
Tags: #frameworks, #build_system
Differential Revision: https://phabricator.kde.org/D10201
|
|
Summary: Without any hint, qmlplugindump version is whatever default is set by qtchooser.
Test Plan: ecm_find_qmlmodule now works properly for e.g. kirigami.
Reviewers: apol, cgiboudeaux
Reviewed By: cgiboudeaux
Subscribers: aacid, dfaure, cgiboudeaux, #frameworks, #build_system
Tags: #frameworks, #build_system
Differential Revision: https://phabricator.kde.org/D9116
|
|
BUG: 389519
|
|
Summary:
We already have rpaths anyway and it breaks running applications from
within the build directory:
https://community.kde.org/Guidelines_and_HOWTOs/Making_apps_run_uninstalled
Reviewers: #frameworks, dfaure, ngraham, graesslin
Reviewed By: ngraham, graesslin
Subscribers: graesslin, ngraham, #build_system
Tags: #frameworks, #build_system
Differential Revision: https://phabricator.kde.org/D9550
|
|
Summary: This is copied from KScreenlocker, but will be utilized in Baloo too.
Test Plan:
- Autotests are working
- KScreenlocker and Baloo build with seccomp enabled
Reviewers: graesslin, cgiboudeaux
Reviewed By: cgiboudeaux
Subscribers: cgiboudeaux, #frameworks, #build_system
Tags: #frameworks, #build_system
Differential Revision: https://phabricator.kde.org/D8998
|
|
For locales like de_AT, the current code only looks in
share/locale/de_AT/ and share/locale/de-AT/ for translation catalogs,
but not in share/locale/de/ where they most likely are.
That's because bcp47Name() returns "de-AT" for de_AT (though in the
case of de_DE e.g. it does return "de").
This patch additionally tries to fall back to the general language by
taking the part of the locale name before the first '_'.
Differential Revision: https://phabricator.kde.org/D9793
|
|
Summary:
Without this i get
In file included from /home/tsdgeos/Android/Sdk/ndk-bundle/sources/cxx-stl/gnu-libstdc++/4.9/include/bits/stl_algo.h:59:0,
from /home/tsdgeos/Android/Sdk/ndk-bundle/sources/cxx-stl/gnu-libstdc++/4.9/include/algorithm:62,
from /home/tsdgeos/devel/binaryQt/5.9.2/android_armv7/include/QtCore/qglobal.h:109,
from /home/tsdgeos/devel/binaryQt/5.9.2/android_armv7/include/QtGui/qtguiglobal.h:43,
from /home/tsdgeos/devel/binaryQt/5.9.2/android_armv7/include/QtWidgets/qtwidgetsglobal.h:43,
from /home/tsdgeos/devel/binaryQt/5.9.2/android_armv7/include/QtWidgets/qapplication.h:43,
from /home/tsdgeos/devel/binaryQt/5.9.2/android_armv7/include/QtWidgets/QApplication:1,
from /home/tsdgeos/devel/kde/ktuberling/main_mobile.cpp:11:
/home/tsdgeos/Android/Sdk/ndk-bundle/sources/cxx-stl/gnu-libstdc++/4.9/include/cstdlib:72:20: fatal error: stdlib.h: No such file or directory
#include <stdlib.h>
^
compilation terminated.
Reviewers: apol
Reviewed By: apol
Subscribers: apol, vkrause, #frameworks, #build_system
Tags: #frameworks, #build_system
Differential Revision: https://phabricator.kde.org/D9899
|