Age | Commit message (Collapse) | Author |
|
|
|
|
|
Use the variable we just created to look up Qt5.
Remove debug warning.
|
|
Summary:
Otherwise we hit a weird code path on androiddeployqt. This is what the official SDK looks like anyway:
```
$ ls /opt/Qt/5.10.1/android_armv7/
bin doc include jar lib mkspecs plugins qml src translations
```
Reviewers: vkrause
Reviewed By: vkrause
Subscribers: #frameworks, #build_system
Tags: #frameworks, #build_system
Differential Revision: https://phabricator.kde.org/D12269
|
|
|
|
Summary:
Refactor the apk-generating code into a separate function, in views of
eventually even make it a module.
It also changes so that if no APK dir is specified, a generic dummy one is
used. Useful for proofs of concept.
Test Plan: Built kate, got kate and kwrite apks
Reviewers: #frameworks, #build_system, vkrause
Reviewed By: vkrause
Subscribers: vkrause
Tags: #frameworks, #build_system
Differential Revision: https://phabricator.kde.org/D12150
|
|
Summary:
Back in the KDE Edu sprint, we decided we need such a check, otherwise
you get rather frustrated when the application isn't started. A patch to
androiddeployqt was submitted but rejected by the maintainer.
https://codereview.qt-project.org/#/c/207941/
Test Plan: kate doesn't build if we don't pass Q_DECL_EXPORT, builds if we do.
Reviewers: #frameworks, #build_system, vkrause
Reviewed By: vkrause
Subscribers: vkrause, vatra, aacid
Tags: #frameworks, #build_system
Differential Revision: https://phabricator.kde.org/D12120
|
|
concepts
Summary: Mark as deprecated the redundant variables and focus on the difference.
Reviewers: #build_system, #frameworks, vkrause
Reviewed By: vkrause
Subscribers: vkrause
Tags: #frameworks, #build_system
Differential Revision: https://phabricator.kde.org/D11984
|
|
Summary:
Instead of having ad-hoc code for gcc, let CMake do its thing. It has a lot of
logic that we may be interested in, for example it will make the clang switch
much smoother.
Note it raises the minimum cmake to 3.7 for Android, which was released almost
2 years ago.
Test Plan: Built kalgebra on it using kdeorg/android-sdk
Reviewers: #frameworks, #build_system, vkrause
Reviewed By: vkrause
Subscribers: vkrause
Tags: #frameworks, #build_system
Differential Revision: https://phabricator.kde.org/D11776
|
|
|
|
Summary:
This macro helps with setting up all the boilerplate CMake code needed
to instruct automoc about the custom C++ macros used to define Qt-style
plugin class instances.
Reviewers: #build_system, #frameworks, apol
Reviewed By: apol
Subscribers: apol
Tags: #frameworks, #build_system
Differential Revision: https://phabricator.kde.org/D10749
|
|
Summary:
This is needed for a new feature in Qt 5.12, making androiddepolyqt's
recursive dependency resolution avaiable for components installed in
different prefixes too.
This will allow us to drop our own partial ELF dependency parsing code
eventually, as well as avoid having to do workarounds like linking against
all indirect dependencies.
Reviewers: #build_system, apol
Reviewed By: apol
Subscribers: #frameworks
Tags: #frameworks, #build_system
Differential Revision: https://phabricator.kde.org/D11388
|
|
Summary: qmake also generates it and androiddeployqt consumes it.
Test Plan: built and ran kalgebra
Reviewers: #frameworks, vkrause
Reviewed By: vkrause
Subscribers: vkrause, #build_system
Tags: #frameworks, #build_system
Differential Revision: https://phabricator.kde.org/D11342
|
|
Summary: qmlimportscanner fails when provided symlinks, so work around that.
Reviewers: #build_system, apol
Reviewed By: apol
Subscribers: #frameworks
Tags: #frameworks, #build_system
Differential Revision: https://phabricator.kde.org/D11181
|
|
|
|
Summary:
This makes the qmlimportscanner find our QML files and plugins correctly.
That's IMHO much cleaner than the full copy of everything in the lib/qml
folder we do via the android-extra-plugins list.
Reviewers: #build_system, apol
Reviewed By: apol
Subscribers: #frameworks
Tags: #frameworks, #build_system
Differential Revision: https://phabricator.kde.org/D11177
|
|
|
|
Summary:
This is needed for NDK headers to work correctly, and is the same as the
CMake code in the NDK does.
Reviewers: #build_system, apol
Reviewed By: apol
Subscribers: apol, #frameworks
Tags: #frameworks, #build_system
Differential Revision: https://phabricator.kde.org/D10777
|
|
Summary:
The prefix for the command is i686-linux-android, while the toolchain is
x86 in this case. On ARM both values are the same.
Reviewers: #build_system, apol
Reviewed By: apol
Subscribers: #frameworks
Tags: #frameworks, #build_system
Differential Revision: https://phabricator.kde.org/D10625
|
|
Summary:
Those affect policy propagation and search path order for relative
includes in CMake code, none of which is needed here. This silences
a ton of warnings with CMake 3.10.
Reviewers: #build_system, apol
Reviewed By: apol
Subscribers: #frameworks
Tags: #frameworks, #build_system
Differential Revision: https://phabricator.kde.org/D10602
|
|
Summary: This allows e.g. KArchive to find zlib correctly.
Reviewers: #build_system, apol
Reviewed By: apol
Subscribers: #frameworks
Tags: #frameworks, #build_system
Differential Revision: https://phabricator.kde.org/D10601
|
|
Summary:
This allows easy platforms checks in CMake files, and is the same the
CMake files shipped by the Android SDK use.
Reviewers: #build_system, apol
Reviewed By: apol
Subscribers: #frameworks
Tags: #frameworks, #build_system
Differential Revision: https://phabricator.kde.org/D10600
|
|
Summary:
ANDROID_TOOLCHAIN is "x86" there, while the include path we want is
"i686-linux-android". ANDROID_COMPILER_PREFIX has that value in all
cases (for ARM both are the same, so nothing changes there).
Reviewers: #build_system, apol
Reviewed By: apol
Subscribers: apol, dfaure, #frameworks
Tags: #frameworks, #build_system
Differential Revision: https://phabricator.kde.org/D10599
|
|
Summary:
For ARM it's not necessary, but when building for a x86 tablet I had to
set ANDROID_TOOLCHAIN=x86 while gcc/g++ are prefixed with
i686-linux-android.
i.e. the path is android-ndk-r10e/toolchains/x86-4.9/prebuilt/linux-x86_64/bin/i686-linux-android-g++
Test Plan: cmake picks up the right compiler for me now
Reviewers: apol, mart
Reviewed By: apol
Subscribers: #build_system, #frameworks
Tags: #frameworks, #build_system
Differential Revision: https://phabricator.kde.org/D10462
|
|
|
|
Summary: Instead of hardcoded /usr/lib, same solution as in D9116
Test Plan: Works fine with kwayland 5.42.0.
Reviewers: #frameworks, #build_system, cgiboudeaux
Reviewed By: cgiboudeaux
Tags: #frameworks, #build_system
Differential Revision: https://phabricator.kde.org/D10201
|
|
Summary: Without any hint, qmlplugindump version is whatever default is set by qtchooser.
Test Plan: ecm_find_qmlmodule now works properly for e.g. kirigami.
Reviewers: apol, cgiboudeaux
Reviewed By: cgiboudeaux
Subscribers: aacid, dfaure, cgiboudeaux, #frameworks, #build_system
Tags: #frameworks, #build_system
Differential Revision: https://phabricator.kde.org/D9116
|
|
BUG: 389519
|
|
Summary:
We already have rpaths anyway and it breaks running applications from
within the build directory:
https://community.kde.org/Guidelines_and_HOWTOs/Making_apps_run_uninstalled
Reviewers: #frameworks, dfaure, ngraham, graesslin
Reviewed By: ngraham, graesslin
Subscribers: graesslin, ngraham, #build_system
Tags: #frameworks, #build_system
Differential Revision: https://phabricator.kde.org/D9550
|
|
Summary: This is copied from KScreenlocker, but will be utilized in Baloo too.
Test Plan:
- Autotests are working
- KScreenlocker and Baloo build with seccomp enabled
Reviewers: graesslin, cgiboudeaux
Reviewed By: cgiboudeaux
Subscribers: cgiboudeaux, #frameworks, #build_system
Tags: #frameworks, #build_system
Differential Revision: https://phabricator.kde.org/D8998
|
|
For locales like de_AT, the current code only looks in
share/locale/de_AT/ and share/locale/de-AT/ for translation catalogs,
but not in share/locale/de/ where they most likely are.
That's because bcp47Name() returns "de-AT" for de_AT (though in the
case of de_DE e.g. it does return "de").
This patch additionally tries to fall back to the general language by
taking the part of the locale name before the first '_'.
Differential Revision: https://phabricator.kde.org/D9793
|
|
Summary:
Without this i get
In file included from /home/tsdgeos/Android/Sdk/ndk-bundle/sources/cxx-stl/gnu-libstdc++/4.9/include/bits/stl_algo.h:59:0,
from /home/tsdgeos/Android/Sdk/ndk-bundle/sources/cxx-stl/gnu-libstdc++/4.9/include/algorithm:62,
from /home/tsdgeos/devel/binaryQt/5.9.2/android_armv7/include/QtCore/qglobal.h:109,
from /home/tsdgeos/devel/binaryQt/5.9.2/android_armv7/include/QtGui/qtguiglobal.h:43,
from /home/tsdgeos/devel/binaryQt/5.9.2/android_armv7/include/QtWidgets/qtwidgetsglobal.h:43,
from /home/tsdgeos/devel/binaryQt/5.9.2/android_armv7/include/QtWidgets/qapplication.h:43,
from /home/tsdgeos/devel/binaryQt/5.9.2/android_armv7/include/QtWidgets/QApplication:1,
from /home/tsdgeos/devel/kde/ktuberling/main_mobile.cpp:11:
/home/tsdgeos/Android/Sdk/ndk-bundle/sources/cxx-stl/gnu-libstdc++/4.9/include/cstdlib:72:20: fatal error: stdlib.h: No such file or directory
#include <stdlib.h>
^
compilation terminated.
Reviewers: apol
Reviewed By: apol
Subscribers: apol, vkrause, #frameworks, #build_system
Tags: #frameworks, #build_system
Differential Revision: https://phabricator.kde.org/D9899
|
|
|
|
Summary:
We were using a link.txt file that cmake used to generate, on newer cmake
versions it doesn't anymore.
Instead use readelf, much like androiddeployqt does, to extract the
depenencies.
Catch: It relies on having all the binaries being at the same subdirectory,
which is the default in ECM since not long ago.
Test Plan: Build kirigamigallery with it
Reviewers: #frameworks, #build_system, aacid
Reviewed By: aacid
Subscribers: mart
Tags: #frameworks, #build_system
Differential Revision: https://phabricator.kde.org/D8173
|
|
Summary:
If enabled it will install a prefix.sh script to the root of the prefix.
This file will be useful to be able to easily set up a prefix to be used by
integrating the environment variables it exports.
Test Plan:
```
$ cat prefix.sh
export PATH=/home/apol/devel/kde5/bin:$PATH
export LD_LIBRARY_PATH=/home/apol/devel/kde5/lib64:$LD_LIBRARY_PATH
export XDG_DATA_DIRS=/home/apol/devel/kde5/share:${XDG_DATA_DIRS:-/usr/local/share/:/usr/share/}
export XDG_CONFIG_DIRS=/home/apol/devel/kde5/etc/xdg:${XDG_CONFIG_DIRS:-/etc/xdg}
export QT_PLUGIN_PATH=/home/apol/devel/kde5/lib64/plugins:$QT_PLUGIN_PATH
export QML2_IMPORT_PATH=/home/apol/devel/kde5/lib64/qml:$QML2_IMPORT_PATH
```
Reviewers: #frameworks, sitter
Reviewed By: sitter
Subscribers: kfunk, bcooksley, ngraham, sitter, cgiboudeaux, #build_system
Tags: #frameworks, #build_system
Differential Revision: https://phabricator.kde.org/D9299
|
|
|
|
Summary:
pkgconfig complains when the .pc file doesn't have a description. eg:
$ pkg-config Baloo
Package 'Baloo' has no Description: field
With this change, if the DESCRIPTION parameter is not used,
ECM_GENERATE_PKGCONFIG_FILE will :
- First look if there's a metainfo.yaml file and get the description from there
- If the file doesn't exist, or if the description tag is empty or non-existent,
create a description based on the LIB_NAME value
Test Plan: Tests added & pass
Reviewers: dfaure, apol
Reviewed By: dfaure
Subscribers: #frameworks, #build_system
Tags: #frameworks, #build_system
Differential Revision: https://phabricator.kde.org/D9056
|
|
Summary:
We need to separate paths in environment variables
with a semincolon (;) on Windows.
Reviewers: dfaure
Subscribers: #frameworks, #build_system
Tags: #frameworks, #build_system
Differential Revision: https://phabricator.kde.org/D8979
|
|
|
|
Summary:
Commit ee5b036c1df4776a258c0d8067fd2eaf18875829 added a new FindPulseAudio module with a slightly different syntax than the old one. Since the old module was removed with commit 7574022825804db2274bba992d6fc4a4817c1536 plasma-desktop and plasma-pa are broken. Just adding the old syntax as synonym for fixing this.
See also https://bugs.kde.org/show_bug.cgi?id=386659
Test Plan: compile tested with plasma-desktop
Reviewers: #frameworks, cgiboudeaux
Reviewed By: cgiboudeaux
Subscribers: jriddell, ngraham, rikmills, cgiboudeaux, #build_system
Tags: #frameworks, #build_system
Differential Revision: https://phabricator.kde.org/D8777
|
|
|
|
Creating new requests using reviewboard is not allowed anymore.
|
|
Summary:
We have copies of this module in several PIM repositories (kdepim-runtime,
kldap, kimap, libksieve...).
It's time to move it to ECM and get rid of these copies.
Reviewers: #kde_pim, vkrause
Reviewed By: #kde_pim, vkrause
Subscribers: #frameworks, #build_system
Tags: #frameworks, #build_system, #kde_pim
Differential Revision: https://phabricator.kde.org/D8790
|
|
Ninja chokes on the $
|
|
|
|
Differential Revision: https://phabricator.kde.org/D7823
|
|
Will initially be used by KMix.
Differential Revision: https://phabricator.kde.org/D7823
|
|
Summary:
This of course requires running the unittests via ctest rather than
launching the executable directly.
Test Plan:
`ctest -V -R kurifiltertest` in kio, which prints QCoreApplication::libraryPaths() at the beginning of the test.
With this commit, builddir/kio/bin is added at the front of the list, and the kurifilter plugins from kio's build are loaded.
Reviewers: cgiboudeaux, kfunk
Reviewed By: cgiboudeaux
Subscribers: #frameworks, #build_system
Tags: #frameworks, #build_system
Differential Revision: https://phabricator.kde.org/D8660
|
|
Reviewers: kossebau
Subscribers: #build_system, #frameworks
Tags: #frameworks, #build_system
Differential Revision: https://phabricator.kde.org/D7612
|
|
|