Age | Commit message (Collapse) | Author |
|
SVG files that fail to convert will still trigger a warning.
|
|
Inform the user that SVG icons can now be provided in the macro call;
on Mac the first that converts to .icns (if ksvg2icns is available) will
provide the application icon. Other SVG files are ignored, idem on
other platforms.
|
|
The Q_DECLARE_TR_FUNCTIONS macro contains a `public:` access specifier,
but the sip_generator just pastes the entire macro name. Adjust the
generator to extract the correct access specifier.
|
|
|
|
KIconThemes comes with a ksvg2icns utility that converts .sgv and .sgvz
files to native .icns icon files. Using this utility allows to create
icons with optimum resolution regardless of the available .png images
and of limitations of the host's iconutil application (limited to
256x256 on some Mac OS versions).
REVIEW: 128162
|
|
|
|
Note which rule has a modification effect.
|
|
Increase test coverage regarding transformations.
|
|
It is unused.
|
|
|
|
gitignore files hide things which should not be hidden. KDE repos
usually don't contain them. Anyone wanting to use a gitignore file can
add it to their home directory more conveniently that individual repos
like this.
|
|
|
|
Summary: Cut-and-paste-o from the Python detection code.
Reviewers: #frameworks, skelly, apol
Reviewed By: apol
Subscribers: #buildsystem
Tags: #frameworks, #buildsystem
Differential Revision: https://phabricator.kde.org/D3952
|
|
This reverts commit d1d637fadd6dad68995d44101250ebbc3307ed0b.
This is far too noisy.
The correct steps for this kind of change are:
* Enable the warning locally
* Take the action recommended by the warning in the code, and push the
result
* Push the warning on everyone to enforce that the code stays fixed for
the future
|
|
Summary:
If you just built the software without installing it and then run ctest,
this will systematically fail while trying to read install_manifest.txt.
With this patch this case is now handled gracefully, not forcing to
install to have a test suite which fully passes.
Reviewers: #frameworks, apol
Differential Revision: https://phabricator.kde.org/D3860
|
|
Test plan: Clang and GCC for simple C project, kcoreaddons, kjs, etc.
BUG: 374195
REVIEW: 129708
Reviewers: #extracmakemodules, alexmerry
Reviewed By: dfaure, aacid
|
|
REVIEW: 129724
|
|
Summary:
Colored compiler warnings in ninja output only work with the
`-fdiagnostics-color=always` flag.
See https://github.com/ninja-build/ninja/issues/814 for a rationale.
This commit adds such flag in ecm for gcc >= 4.9 and clang >= 3.5,
and only if the CMAKE_GENERATOR is Ninja.
Test Plan: ninja+gcc and ninja+clang now show nice colored compiler warnings.
Reviewers: #frameworks
Differential Revision: https://phabricator.kde.org/D3733
|
|
This reverts commit 1e7f3d5ba91e79a47d69a48e8f991ee0e7794b53.
It's breaking compilation of anything that uses pthreads
|
|
BUG: 374195
REVIEW: 129708
Reviewers: #extracmakemodules, alexmerry
Reviewed By: dfaure
|
|
|
|
Summary:
Currently (since 123d0d14017a25fb387efd8fe3c2c1323f9c3815) any
find_library() and find_path() calls look both at the host and the toolchain
paths, which often results in includes and/or libraries wrongly being picked
up from the host system, which then results in a failed build.
CMake config files have always been also looked for on the host, which
most often also is not wanted and resulting in a failed build.
This patch fixes that by changing the mode for finding libraries,
includes & packages to ONLY (again), as also recommended in the
cmake-toolchains documentation.
While before CMAKE_PREFIX_PATH was recommended to let cmake e.g.
discover the Qt5 for Android libs, this patch wants a custom
variable ECM_ADDITIONAL_FIND_ROOT_PATH to be used instead.
Reason is that CMAKE_PREFIX_PATH would be subject to the root
handling, while here instead the root paths themselves are
wanted.
This patch does not add backward compatibility for still passing
the Qt5 install prefix via CMAKE_PREFIX_PATH, as there are not
that many users known yet and the old code did not work for many
anyway, so the extra code hassle is not worth it. Instead the few
build instructions would need to be updated (and should ask to use
latest ECM in any case).
Test Plan:
Building Marble now works without trying to use stuff from the
host system.
Reviewers: #frameworks, #gcompris, #minuet, mutlaqja, sandsmark, cordlandwehr, nienhueser, apol
Reviewed By: cordlandwehr, nienhueser, apol
Differential Revision: https://phabricator.kde.org/D3646
|
|
Reviewers: #frameworks, cordlandwehr, apol
Reviewed By: apol
Differential Revision: https://phabricator.kde.org/D3732
|
|
|
|
While unusual it is not impossible to use GCC on Macs, esp. not when
using older OS X versions. Intel also makes compilers for Mac, so it may
in fact be better to rewrite the check ((GNU or Clang or Intel) IF NOT
(APPLE or WIN32)).
|
|
Apple's clang v3.1 corresponds to clang 3.1 and started following the
Xcode versioning scheme from 4.4 onwards (though loosely). An overview
of the version correspondance can be found here:
https://gist.github.com/yamaya/2924292
|
|
Summary: When running tests with hardcoded `cmake`, it get's suffixed to the project's build path. Setting it with an absolute path ensures using the right cmake binary.
Test Plan: Compiled, installed. Used to generate tests for kdev-embedded. `cmake` binary is now prefixed with the absolute system path, and no longer with the project's build dir.
Reviewers: kfunk, #frameworks, apol
Reviewed By: kfunk, apol
Subscribers: kfunk
Differential Revision: https://phabricator.kde.org/D3568
|
|
GIT_SILENT
|
|
Triggered my OCD
|
|
https://commits.kde.org/<repo>?path=...&branch=... is guaranteed to
redirect to the proper repository browser.
Add a link to the generated ECM documentation.
REVIEW: 129367
|
|
also correct link to clazy's README.md (former README)
|
|
|
|
|
|
|
|
This works with 3.2, and I don't remember why I made it 3.3.
|
|
Don't rely on transitive inclusion
|
|
|
|
REVIEW: 128112
|
|
REVIEW: 128806
|
|
It should be optional.
|
|
This can be used by KF5 libraries to generate python 2 and 3 bindings.
|
|
When sip is executed it is passed one .sip file. However, it uses that
to generate multiple cpp source files, one per class in the sip file.
Buildsystems need to know the outputs of commands, so this does not work
well as the output can't easily be predicted.
So, create a unity build of all files to compile into the python module.
|
|
The ruleset is used to transform or omit artifacts in C++ header files
when determining the SIP content to generate. Some content common to
all Qt-using libraries can be processed by using the rule set present
here. For example, most Q_METATYPE internal declarations should be
discarded.
|
|
These files process C++ headers with libclang and python-clang bindings,
using the AST to generate SIP files for PyQt binding library generation.
The design allows for further extensions which can process other
artifacts found in headers. This iteration of the design is a simple
minimum which suffices to generate headers for KItemModels and some
other libraries.
|
|
|
|
that simulates MSVC."
This reverts commit 4b8e8dcc8856d8f438860783e7641d02d1c05630.
|
|
simulates MSVC.
REVIEW: 128779
|
|
Guard variable we used to ensure this doesn't happen was not scopped to
parent and hence was being reset when funciton returns
REVIEW: 128917
|
|
|
|
|