Age | Commit message (Collapse) | Author |
|
The V1 syntax of ecm_install_icons searched for icons by globbing files
with a particular naming pattern. If there were no such icons, this used
to do nothing, but silently. Commit fb7b8eea7d accidentally made this an
error. More sensible would be to make it a warning.
BUG: 354610
REVIEW: 125931
|
|
CCMAIL: kde-licensing@kde.org
CCMAIL: agateau@kde.org
|
|
LANGUAGE has higher priority than LC_ALL.
|
|
This is easier to distinguish from "english" in the test output than
"british english".
|
|
|
|
BUG: 346188
REVIEW: 123726
|
|
ECMInstallIcons now updates the theme cache if gtk-update-icon-cache is
available, producing files the test hadn't been expecting.. Updating the
test revealed that the old-style ecm_install_icons call only updated the
hicolor cache, and not any of the other themes.
REVIEW: 125631
|
|
from the normal qt.io installer on mac os
we can revisit this change, if it leads to problems for mac ports or homebrew
REVIEW: 125614
|
|
|
|
Despite the name, Qt is also using this, and it considerably speeds up
icon lookup.
REVIEW: 125192
|
|
* Remove get_property calls on targets, this way we don't need to be called
right before configuration time.
* Removes EOFHook
Instead we process it at generation time using the link.txt file (which is
probably another hack)
REVIEW: 125084
|
|
|
|
Reviewed at https://git.reviewboard.kde.org/r/125163/
|
|
In general, we are looking for what we're installing, not for what we
already had.
|
|
|
|
|
|
QtCore/qsystemdetection.h sets the define Q_OS_ANDROID based on having
ANDROID defined. Hence, adding the ANDROID define allows applications to
use the Q_OS_ANDROID for ifdef'ing.
REVIEW: 125183
|
|
This warning is emitted for every qCDebug() call and is not useful.
REVIEW: 125031
|
|
This adds a new keyword COMMON_HEADER which generates a new header
containing all other headers. Also it is possible now to have multiple
dummy headers per header file. It is assumed that the first header is the
existing one.
REVIEW: 124847
|
|
|
|
|
|
This makes life a bit easier for developers who use the categorised
logging in Qt5 in the common case - rather than creating two new files,
and remembering to put in the #ifdef for the default verbosity settings
in Qt 5.4, they can just add a couple of lines to their CMakeLists.txt.
REVIEW: 124595
|
|
REVIEW: 124763
|
|
(they are slower). And enable them on MSVC now that we rely on Qt 5.3, as the comment said.
REVIEW: 124762
|
|
This prevents accidental "leaking" of symbols from internal code, such
as flex/bison generated parsers.
REVIEW: 124740
|
|
|
|
|
|
In case it fails, offer an error message and the attempted call, to make
sure we can react accordingly.
Note that the proper error argument is FATAL_ERROR, not FATAL.
REVIEW: 124106
|
|
|
|
CI said:
Linking C executable dummy.app/Contents/MacOS/dummy
Built target dummy
Could not find path to executable, perhaps it was not built: dummy
REVIEW: 123969
|
|
This makes it convenient to make further modifications to the tests,
such as setting properties on either the tests or the targets.
CHANGELOG: New arguments for ecm_add_tests().
BUG: 345797
REVIEW: 123841
|
|
ecm_add_test is the less useful (and less used) version of the functions
(because you really might as well just use add_executable() and
add_test() manually in that case).
REVIEW: 123841
|
|
This reverts commit 0c224194ea7f12eaed32af746fc9138537f1919c.
Stephen Kelly pointed out that this is probably not the best approach to
the problem, and runs counter to the direction KDE's CMake code has been
going (splitting functions up and using CMake built-ins where possible).
I have a better solution in mind, which I'll post a review for later.
CCMAIL: kde-buildsystem@kde.org
CCBUG: 345797
|
|
This is particularly useful with ecm_add_tests, where you may want to
force a suite of tests to run in serial, or alter the timeout for
multiple tests at once.
BUG: 345797
REVIEW: 123722
|
|
REVIEW: 123722
|
|
|
|
REVIEW: 123470
|
|
|
|
http://www.winterdrache.de/freeware/png2ico/
|
|
|
|
According to Oswald Buddenhagen "it doesn't buy much, and there are
some long-standing issues with it".
Qt bug report: https://bugreports.qt.io/browse/QTBUG-44362
REVIEW: 122501
|
|
CHANGELOG: extra-cmake-modules versioning is now aligned with KDE Frameworks.
Therefore the last release was 1.8, while this one is 5.9.
|
|
|
|
Through a quirk of implementation, old-style icon filenames are accepted
by the new-style ecm_install_icons function. It's too late to change it
now, as that would break existing projects, but we can warn about it.
REVIEW: 122941
|
|
The motivation behind this change is my distribution moving to a multiarch layout. While the architecture specific stuff (binaries, libraries, etc.) is installed under /usr/${host}/{bin,lib,...} architecture-independent data should still be installed to /usr/share/.
REVIEW: 122929
From 014d2166e08cbe6f350a8600a93c8f132ee95661 Mon Sep 17 00:00:00 2001
From: Heiko Becker <heirecka@exherbo.org>
Date: Fri, 13 Mar 2015 12:26:31 +0100
Subject: [PATCH] Allow configuration of SHARE_INSTALL_DIR
|
|
There is no "\t" in CMake's regular expression syntax; we need to make
the character be interpreted when CMake parses it as a string.
|
|
Qt5LinguistToolsConfig.cmake defines CMake target for lconvert since Qt 5.3.1,
so we should use that if it is available.
Our own hacks were not working in some configurations (i.e. when there is
/usr/bin/lconvert managed by qtchooser, but no qtchooser configuration file).
REVIEW: 122626
|
|
In particular, strongly recommend looking at the equivalent CMake
documentation with regard to PATH_VARS, as a lot of projects that should
be making use of it are not.
|
|
|
|
REVIEW: 122317
Thanks alexmerry and dvratil for review
|