aboutsummaryrefslogtreecommitdiff
path: root/automoc/kde4automoc.cpp
diff options
context:
space:
mode:
Diffstat (limited to 'automoc/kde4automoc.cpp')
-rw-r--r--automoc/kde4automoc.cpp17
1 files changed, 9 insertions, 8 deletions
diff --git a/automoc/kde4automoc.cpp b/automoc/kde4automoc.cpp
index da0d5457..68ccdbdb 100644
--- a/automoc/kde4automoc.cpp
+++ b/automoc/kde4automoc.cpp
@@ -47,7 +47,7 @@ class AutoMoc
cmakeEcho->setProcessChannelMode(QProcess::ForwardedChannels);
QStringList args(cmakeEchoColorArgs);
args << msg;
- cmakeEcho->start("cmake", args, QIODevice::NotOpen);
+ cmakeEcho->start(QLatin1String("cmake"), args, QIODevice::NotOpen);
processes.enqueue(Process(cmakeEcho, QString()));
}
@@ -87,8 +87,9 @@ AutoMoc::AutoMoc()
: verbose(!qgetenv("VERBOSE").isEmpty()), cerr(stderr), cout(stdout), failed(false)
{
const QByteArray colorEnv = qgetenv("COLOR");
- cmakeEchoColorArgs << "-E" << "cmake_echo_color" << QString("--switch=") + colorEnv << "--blue"
- << "--bold";
+ cmakeEchoColorArgs << QLatin1String("-E") << QLatin1String("cmake_echo_color")
+ << QLatin1String("--switch=") + colorEnv << QLatin1String("--blue")
+ << QLatin1String("--bold");
}
bool AutoMoc::run()
@@ -136,8 +137,8 @@ bool AutoMoc::run()
QHash<QString, QString> includedMocs; // key = moc source filepath, value = moc output filepath
QHash<QString, QString> notIncludedMocs; // key = moc source filepath, value = moc output filename
- QRegExp mocIncludeRegExp("[\n]\\s*#\\s*include\\s+[\"<](moc_[^ \">]+\\.cpp|[^ \">]+\\.moc)[\">]");
- QRegExp qObjectRegExp("[\n]\\s*Q_OBJECT\\b");
+ QRegExp mocIncludeRegExp(QLatin1String("[\n]\\s*#\\s*include\\s+[\"<](moc_[^ \">]+\\.cpp|[^ \">]+\\.moc)[\">]"));
+ QRegExp qObjectRegExp(QLatin1String("[\n]\\s*Q_OBJECT\\b"));
QStringList headerExtensions;
headerExtensions << ".h" << ".hpp" << ".hxx" << ".H";
foreach (const QString &absFilename, sourceFiles) {
@@ -196,7 +197,7 @@ bool AutoMoc::run()
basename = basename.right(basename.length() - 4);
}
bool headerFound = false;
- foreach (QString ext, headerExtensions) {
+ foreach (const QString &ext, headerExtensions) {
QString sourceFilePath = absPath + basename + ext;
if (QFile::exists(sourceFilePath)) {
headerFound = true;
@@ -314,7 +315,7 @@ void AutoMoc::generateMoc(const QString &sourceFile, const QString &mocFileName)
// we don't want too many child processes
#ifdef Q_OS_FREEBSD
- static const int max_processes = 1;
+ static const int max_processes = 0;
#else
static const int max_processes = 10;
#endif
@@ -329,7 +330,7 @@ void AutoMoc::generateMoc(const QString &sourceFile, const QString &mocFileName)
#ifdef Q_OS_WIN
args << "-DWIN32";
#endif
- args << "-o" << mocFilePath << sourceFile;
+ args << QLatin1String("-o") << mocFilePath << sourceFile;
//qDebug() << "executing: " << mocExe << args;
mocProc->start(mocExe, args, QIODevice::NotOpen);
if (mocProc->waitForStarted())