aboutsummaryrefslogtreecommitdiff
path: root/kde-modules/KDEFrameworkCompilerSettings.cmake
diff options
context:
space:
mode:
authorAlex Merry <kde@randomguy3.me.uk>2014-02-04 19:09:35 +0000
committerAlex Merry <kde@randomguy3.me.uk>2014-02-14 13:23:53 +0000
commit7fcc57a2055f04ca1af880e18309f5d1ecfc5f3c (patch)
tree1ae9d404727945584ae3b3c92cbb65dc2c127a66 /kde-modules/KDEFrameworkCompilerSettings.cmake
parent2ec165030b2947e6a4e1b29843b20fbff17aaa1f (diff)
downloadextra-cmake-modules-7fcc57a2055f04ca1af880e18309f5d1ecfc5f3c.tar.gz
extra-cmake-modules-7fcc57a2055f04ca1af880e18309f5d1ecfc5f3c.tar.bz2
Improve docs for kde modules
REVIEW: 115488
Diffstat (limited to 'kde-modules/KDEFrameworkCompilerSettings.cmake')
-rw-r--r--kde-modules/KDEFrameworkCompilerSettings.cmake15
1 files changed, 13 insertions, 2 deletions
diff --git a/kde-modules/KDEFrameworkCompilerSettings.cmake b/kde-modules/KDEFrameworkCompilerSettings.cmake
index 0799a8d7..d0bf4dd7 100644
--- a/kde-modules/KDEFrameworkCompilerSettings.cmake
+++ b/kde-modules/KDEFrameworkCompilerSettings.cmake
@@ -1,3 +1,14 @@
+# Set stricter compile and link flags for KDE Frameworks modules
+#
+# The KDECompilerSettings module is included and, in addition, various
+# defines that affect the Qt libraries are set to enforce certain
+# conventions.
+#
+# For example, constructions like QString("foo") are prohibited, instead
+# forcing the use of QLatin1String or QStringLiteral, and some
+# Qt-defined keywords like signals and slots will not be defined.
+#
+
include(KDECompilerSettings)
add_definitions(-DQT_NO_CAST_TO_ASCII
@@ -10,8 +21,8 @@ add_definitions(-DQT_NO_CAST_TO_ASCII
)
if(NOT MSVC)
# QT_STRICT_ITERATORS breaks MSVC: it tries to link to QTypedArrayData symbols
- # when using foreach. However these symbols don't actually exist
- # not having QT_STRICT_ITERATORS defined fixes this issue.
+ # when using foreach. However these symbols don't actually exist.
+ # Not having QT_STRICT_ITERATORS defined fixes this issue.
# This is fixed by https://codereview.qt-project.org/#change,76311
# TODO: set QT_STRICT_ITERATORS on all platforms once we depend on Qt 5.3
add_definitions(-DQT_STRICT_ITERATORS)