diff options
| author | Stefan Brüns <stefan.bruens@rwth-aachen.de> | 2018-08-15 02:37:20 +0200 |
|---|---|---|
| committer | Stefan Brüns <stefan.bruens@rwth-aachen.de> | 2018-08-31 23:41:37 +0200 |
| commit | b6e4e645dac67abf02c01b6f55a55ba0b84ca32e (patch) | |
| tree | ff309a7809ae050118ebea9efab44e4b3162fd3a /find-modules/rules_engine.py | |
| parent | 7d6d5b1e705f54a216f8d5235b66bbf2035d7448 (diff) | |
| download | extra-cmake-modules-b6e4e645dac67abf02c01b6f55a55ba0b84ca32e.tar.gz extra-cmake-modules-b6e4e645dac67abf02c01b6f55a55ba0b84ca32e.tar.bz2 | |
Bindings: Make generator forward compatible with Python 3
Summary:
iteritems is no longer an available method for dict in Python 3. Using
dict.items() is functionally identical, although it creates some overhead
for Python 2.7 (creation of a temporary list). As this is only called
when tracing, this is not a big issue. For Python 3, there is no
overhead (dict.items() returns an iterator).
Test Plan:
Run python3 sip_generator.py ...
Run python2 sip_generator.py ...
Both generate the same code
Reviewers: #frameworks, arojas
Reviewed By: arojas
Subscribers: arojas, kde-frameworks-devel, kde-buildsystem
Tags: #frameworks, #build_system
Differential Revision: https://phabricator.kde.org/D14912
Diffstat (limited to 'find-modules/rules_engine.py')
| -rwxr-xr-x | find-modules/rules_engine.py | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/find-modules/rules_engine.py b/find-modules/rules_engine.py index 8ec5ac5c..25c65a59 100755 --- a/find-modules/rules_engine.py +++ b/find-modules/rules_engine.py @@ -113,7 +113,7 @@ class Rule(object): logger.debug(_("Rule {} suppressed {}, {}").format(self, fqn, original)) else: delta = False - for k, v in original.iteritems(): + for k, v in original.items(): if v != modified[k]: delta = True break @@ -620,7 +620,7 @@ class AbstractCompiledCodeDb(object): logger.debug(_("Rule {} suppressed {}, {}").format(self, fqn, original)) else: delta = False - for k, v in original.iteritems(): + for k, v in original.items(): if v != modified[k]: delta = True break |