diff options
| author | Alex Merry <alex.merry@kde.org> | 2014-04-16 11:06:17 +0100 |
|---|---|---|
| committer | Alex Merry <alex.merry@kde.org> | 2014-04-25 11:07:26 +0100 |
| commit | 0fd08930a4f70a0a696d19eac309f0cb0087dcf6 (patch) | |
| tree | a13dac584670538fe04749c2a5593c5b39fbedfd /docs | |
| parent | eb8a168c7a184770019d7fcf1dd8ad1a0ba02c80 (diff) | |
| download | extra-cmake-modules-0fd08930a4f70a0a696d19eac309f0cb0087dcf6.tar.gz extra-cmake-modules-0fd08930a4f70a0a696d19eac309f0cb0087dcf6.tar.bz2 | |
Remove ECMDBusAddActivationService module
ecm_dbus_add_activation_service() requires suffient knowledge of its
internals to use that replacing two lines with one seems silly.
In order to use it you have to know it behaves like configure_file()
(because you have to construct the file yourself), except that it also
installs it somewhere (for which you have to make sure
DBUS_SERVICES_INSTALL_DIR is defined before you use it, which is
certainly not a given for non-KDE projects). By this point, why not just
use configure_file() and install()? The DBUS_SERVICES_INSTALL_DIR
provided by KDEInstallDirs is all the magic you actually need, and if
that's explicit in the CMakeLists.txt file, it's a lot more obvious that
you should have it defined somewhere.
REVIEW: 117581
Diffstat (limited to 'docs')
| -rw-r--r-- | docs/module/ECMDBusAddActivationService.rst | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/docs/module/ECMDBusAddActivationService.rst b/docs/module/ECMDBusAddActivationService.rst deleted file mode 100644 index 2052faeb..00000000 --- a/docs/module/ECMDBusAddActivationService.rst +++ /dev/null @@ -1 +0,0 @@ -.. ecm-module:: ../../modules/ECMDBusAddActivationService.cmake |