aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAleix Pol <aleixpol@kde.org>2017-04-10 16:23:20 +0200
committerAleix Pol <aleixpol@kde.org>2017-04-10 16:23:20 +0200
commit0a33e0d7e3b5d2ea08647cb99ad0dffff6c558ba (patch)
tree552d1ab98788139975938cfec0125e37be232f3c
parent5b0583b38b43265a2017cde5e739404d7d301e70 (diff)
downloadextra-cmake-modules-0a33e0d7e3b5d2ea08647cb99ad0dffff6c558ba.tar.gz
extra-cmake-modules-0a33e0d7e3b5d2ea08647cb99ad0dffff6c558ba.tar.bz2
Don't enable the test by default
The build isn't always reproducible and comparisons are unfair
-rw-r--r--modules/ECMGenerateQmlTypes.cmake11
1 files changed, 7 insertions, 4 deletions
diff --git a/modules/ECMGenerateQmlTypes.cmake b/modules/ECMGenerateQmlTypes.cmake
index 2ed7be50..0a27b9e1 100644
--- a/modules/ECMGenerateQmlTypes.cmake
+++ b/modules/ECMGenerateQmlTypes.cmake
@@ -55,7 +55,7 @@ function(ecm_generate_qmltypes)
endif ()
set(options)
- set(oneValueArgs DESTINATION)
+ set(oneValueArgs DESTINATION TEST_ENABLED)
cmake_parse_arguments(ARG "${options}" "${oneValueArgs}" "" ${ARGN})
set(targetname "qmltypes-${ARG_UNPARSED_ARGUMENTS}")
@@ -73,7 +73,10 @@ function(ecm_generate_qmltypes)
string(REPLACE ";" / processedArgs "${ARG_UNPARSED_ARGUMENTS}")
- add_test(NAME ${targetname} COMMAND
- cmake -DARG_UNPARSED_ARGUMENTS=${processedArgs} -DKDE_INSTALL_QMLDIR=${KDE_INSTALL_QMLDIR} -DINPUT=${generatedFile} -P ${ECM_MODULE_DIR}/test_execute_and_compare.cmake
- )
+ # sometimes qmlplugindump output isn't reproducible, we better have it opt in for now
+ if(ARG_TEST_ENABLED)
+ add_test(NAME ${targetname} COMMAND
+ cmake -DARG_UNPARSED_ARGUMENTS=${processedArgs} -DKDE_INSTALL_QMLDIR=${KDE_INSTALL_QMLDIR} -DINPUT=${generatedFile} -P ${ECM_MODULE_DIR}/test_execute_and_compare.cmake
+ )
+ endif()
endfunction()