Summary:
Note that the first test had a comment "without optional arguments"
so I removed the INCLUDE_INSTALL_DIR variable to test what happens by
default. The other tests still pass an absolute path there (which is
unusual in practice, and breaks the idea of using ${prefix}).

Test Plan: `ctest -R PkgConfig` passes

Reviewers: kossebau, apol, cgiboudeaux

Reviewed By: apol

Subscribers: kde-frameworks-devel, kde-buildsystem, fazevedo

Tags: #frameworks, #build_system

Differential Revision: https://phabricator.kde.org/D19538

Summary:
If we ever end up in a situation where the generated .pc file is
actually used by cmake's pkg_check_modules, then we need the
includedir and libdir variables; pkg_check_modules ignores the
Makefile-like Libs and Cflags lines of the .pc file.

Context: craft adds a cmake buildsystem for sqlite3, which is then
found using pkgconfig in akonadi.

Test Plan: Filipe Azevedo is doing all the testing, I'm just providing patches :)

Reviewers: apol, fazevedo, cgiboudeaux

Reviewed By: fazevedo, cgiboudeaux

Subscribers: cgiboudeaux, fazevedo, kde-buildsystem, kde-frameworks-devel

Tags: #frameworks, #build_system

Differential Revision: https://phabricator.kde.org/D19506

Found while grepping for examples of foreach(... RANGE ...) for my
cmake training material ;-)

Found while grepping for examples of foreach(... RANGE ...) for my
cmake training material ;-)

Summary:
- Add support for SIDEBAR_ICONS on macOS
- Allow specifying a basename for the icon file via OUTFILE_BASENAME
- Add support for HiRes icons on Windows via icotool

I'm sorry this went all into one big change. I see that it's not optimal,
but it's really hard to rip it apart...

Also to me the whole code with support for two flavors of png2ico and icotool seems very spaghetti-ish. IMHO there's no good reason to keep supporting all three, icotool is the only maintained project and the only one supporting more than 128px wide icons. That's why I would suggest to simplify the whole code by only supporting icotool in one of the next releases.

Test Plan:
We use this version of ECMAddAppIconMacro in ownCloud client and it works...
I tested icotool natively and while cross-compiling on linux.

SIDEBAR_ICONS are also working...

If you want to test this with the ownCloud client, it's best to use
https://github.com/dschmidt/owncloud-client/tree/fix-app-icon-macro
because that contains a small fix I just PR'ed and which is not
in master yet. (We maintain a fork of the module there, so compiling it for Windows or macOS will automatically use the version of the module that I'm submitting)

Reviewers: vonreth, vpinon, apol, alexmerry, cgiboudeaux

Reviewed By: cgiboudeaux

Subscribers: cgiboudeaux, kde-frameworks-devel, kde-buildsystem

Tags: #frameworks, #build_system

Differential Revision: https://phabricator.kde.org/D13698

Summary:
Quite some C++-based projects do not use .h as header file extension, but
.hpp, .hxx or other variants. Making the header file extension configurable
enables to make use of ECMGenerateHeaders in such projects.

Test Plan:
The added unit test works, existing unit tests work as before.
Also using in project with .hpp files works.

Reviewers: apol

Reviewed By: apol

Subscribers: apol, kde-frameworks-devel, kde-buildsystem

Tags: #frameworks, #build_system

Differential Revision: https://phabricator.kde.org/D13721

BUG: 389519