Summary:
pkgconfig complains when the .pc file doesn't have a description. eg:
$ pkg-config Baloo
Package 'Baloo' has no Description: field

With this change, if the DESCRIPTION parameter is not used,
ECM_GENERATE_PKGCONFIG_FILE will :
- First look if there's a metainfo.yaml file and get the description from there
- If the file doesn't exist, or if the description tag is empty or non-existent,
create a description based on the LIB_NAME value

Test Plan: Tests added & pass

Reviewers: dfaure, apol

Reviewed By: dfaure

Subscribers: #frameworks, #build_system

Tags: #frameworks, #build_system

Differential Revision: https://phabricator.kde.org/D9056

Summary:
We need to separate paths in environment variables
with a semincolon (;) on Windows.

Reviewers: dfaure

Subscribers: #frameworks, #build_system

Tags: #frameworks, #build_system

Differential Revision: https://phabricator.kde.org/D8979

Summary:
This of course requires running the unittests via ctest rather than
launching the executable directly.

Test Plan:
`ctest -V -R kurifiltertest` in kio, which prints QCoreApplication::libraryPaths() at the beginning of the test.
With this commit, builddir/kio/bin is added at the front of the list, and the kurifilter plugins from kio's build are loaded.

Reviewers: cgiboudeaux, kfunk

Reviewed By: cgiboudeaux

Subscribers: #frameworks, #build_system

Tags: #frameworks, #build_system

Differential Revision: https://phabricator.kde.org/D8660

This broke a lot of frameworks when built WITH BUILD_TESTING=OFF. I
didn't notice before since kdesrc-build was appending BUILD_TESTING=TRUE
thus re-enabling the tests for me...

This reverts commit b99d2d2c5dedcaba9745dddc1dd7b8d4811babf1.

Needed to revert parent commit

This reverts commit ebbef5afcaee863c62136b14dbd06a7a73cf769a.

Summary:
Allows to check if a module is available on the system and sets it as a
runtime dependency.
This is useful for projects so that they can specify their qml dependencies
easily and packagers and developers get to see what's missing by looking
at the cmake output.

Reviewers: #build_system, #frameworks, sitter

Reviewed By: sitter

Subscribers: dfaure, aacid

Tags: #frameworks, #build_system

Differential Revision: https://phabricator.kde.org/D7094

Summary:
Use-case: Make building unit tests optional, by just following the CMake
BUILD_TESTING option.

The usual approach to conditionally build tests is to do:
```
if (BUILD_TESTING)
    add_executable(TestOne TestOne.cpp)
    target_link_libraries(TestOne my_library)
endif()
```

or:

```
if (BUILD_TESTING)
    add_subdirectory(tests)
endif()
```

This patch just turns all calls to ecm_add_test(...) into no-ops if
BUILD_TESTING=OFF.

See:
  https://cmake.org/cmake/help/v3.6/module/CTest.html

Reviewers: vkrause

Reviewed By: vkrause

Subscribers: kossebau, vkrause, elvisangelaccio, asturmlechner, apol, #frameworks, #build_system

Tags: #frameworks, #build_system

Differential Revision: https://phabricator.kde.org/D7187

Summary:
when KDE_INSTALL_USE_QT_SYS_PATHS has been explicitely set,
qmake can be considered a required dependency, otherwise the
paths will not be known, which would be unexpected.
Also does the code calling query_qmake, besides the one testing
for the same install prefix, not handle the case of empty strings
being returned and then results in bogus behaviour.

Thus this patch makes code fail hard if query_qmake is expected
to yield a result, but no qmake executable is found.

Reviewers: #frameworks, ltoscano, rdieter, apol

Reviewed By: apol

Subscribers: #build_system

Tags: #frameworks, #build_system

Differential Revision: https://phabricator.kde.org/D6772