extra-cmake-modules.git/modules, branch v5.22.0 hurd extra-cmake-modules.git ecm_qt_declare_logging_category: improve error message when using without including 2016-04-03T20:41:42+00:00 David Faure faure@kde.org 2016-03-20T10:52:27+00:00 f7c1e8d57f84d0883a2a7683fd59ecc990a03de1 If one subdir in the project includes this file, all others can use the function but they don't see the value of the variable, which leads to a strange error CMake Error at ECM/modules/ECMQtDeclareLoggingCategory.cmake:114 (configure_file): configure_file input location <srcdir> is a directory but a file was expected. Happened in KIO, with kio/gui doing include+function call, and then adding function call in kio/widgets. REVIEW: 127432 
If one subdir in the project includes this file, all others can use the function
but they don't see the value of the variable, which leads to a strange error

CMake Error at ECM/modules/ECMQtDeclareLoggingCategory.cmake:114 (configure_file):
  configure_file input location <srcdir> is a directory but a file was expected.

Happened in KIO, with kio/gui doing include+function call, and then adding
function call in kio/widgets.

REVIEW: 127432
ECMEnableSanitizers: avoid linking runtime for Clang 2016-03-29T18:13:23+00:00 Peter Wu peter@lekensteyn.nl 2016-03-29T18:13:23+00:00 c6495e75fc6114314512427bce5e202c1ad648c6 Clang automatically adds its runtime library (librt) when given the -fsanitize options. Do not force the GCC runtime libraries (asan, tsan, lsan), this results in "Your application is linked against incompatible ASan runtimes." errors when using the library in an executable built using Clang. Acked by Mathieu Tarral REVIEW: 127513 
Clang automatically adds its runtime library (librt) when given the
-fsanitize options. Do not force the GCC runtime libraries (asan, tsan,
lsan), this results in "Your application is linked against incompatible
ASan runtimes." errors when using the library in an executable built
using Clang.

Acked by Mathieu Tarral

REVIEW: 127513
Fix _ecm_update_iconcache to only update the install location 2016-03-21T21:31:09+00:00 Stephen Kelly steveire@gmail.com 2016-03-21T21:24:56+00:00 928e79cf5d51a3c78d388b7eb972b3dae1ebbb68 Use the CMAKE_INSTALL_PREFIX to ensure that only a file in the install location will be touched. Otherwise a user running make install as root would create root-owned files in the build directory. Use the cmake -E touch command to update the mtime of the directory. That command exists since late 2007, but this manual file creation workaround pre-dates that by a few months (kdelibs SVN revision 691973). There is no chance any calling code is already passing an absolute path here because later in the function it is already used together with a CMAKE_INSTALL_PREFIX. Inspired-by: REVIEW 127445 
Use the CMAKE_INSTALL_PREFIX to ensure that only a file in the install
location will be touched.  Otherwise a user running

 make install

as root would create root-owned files in the build directory.

Use the cmake -E touch command to update the mtime of the directory.
That command exists since late 2007, but this manual file creation
workaround pre-dates that by a few months (kdelibs SVN revision 691973).

There is no chance any calling code is already passing an absolute path
here because later in the function it is already used together with a
CMAKE_INSTALL_PREFIX.

Inspired-by: REVIEW 127445
Revert "ECMQtDeclareLoggingCategory: Include <QDebug> with the generated file" 2016-03-20T18:36:07+00:00 Stephen Kelly steveire@gmail.com 2016-03-20T18:36:07+00:00 09008700af42967f6ad10c9b3ef565cc2f727874 This reverts commit 1d4bc35cf9383177459544d6fcd9de35edf3e77d. QLoggingCategory has always included QDebug, so this has always been superfluous. 
This reverts commit 1d4bc35cf9383177459544d6fcd9de35edf3e77d.

QLoggingCategory has always included QDebug, so this has always been
superfluous.
ECMAddAppIcon: Use absolute path when operating on icons. 2016-01-31T14:55:28+00:00 Gleb Popov 6yearold@gmail.com 2016-01-10T19:32:37+00:00 dde4ba04e57502f13955002d3ea3ae702c3e8c74 REVIEW: 126711 
REVIEW: 126711
Use PATH_SUFFIXES in ecm_find_package_handle_library_components() 2016-01-13T13:51:02+00:00 Alex Richardson arichardson.kde@gmail.com 2015-11-27T12:40:03+00:00 f5126a3ef0a0876f51d6b9ae3d093a930ca1cbf5 This is required to find poppler without package config as all the headers are installed in a poppler subdirectory of the include directory 
This is required to find poppler without package config as all the headers
are installed in a poppler subdirectory of the include directory
ECMQtDeclareLoggingCategory: Include <QDebug> with the generated file 2015-12-21T19:30:33+00:00 Martin Klapetek mklapetek@kde.org 2015-12-21T19:30:19+00:00 1d4bc35cf9383177459544d6fcd9de35edf3e77d In order to use the logging categories created by ECM, the generated header file has to be included but then also #include <QDebug> must be added to make it usable at all for qCDebug/qCWarning stuff. So this puts the #include <QDebug> into the generated header file and thus allowing to include a single header for qCDebug/qCWarning instead of two. REVIEW: 126368 
In order to use the logging categories created by ECM,
the generated header file has to be included but then
also #include <QDebug> must be added to make it usable
at all for qCDebug/qCWarning stuff.

So this puts the #include <QDebug> into the generated
header file and thus allowing to include a single header
for qCDebug/qCWarning instead of two.

REVIEW: 126368
CMake: Cleanup: Strip text from endif/else 2015-12-18T14:57:50+00:00 Kevin Funk kfunk@kde.org 2015-12-18T11:37:19+00:00 942ba80dae253fef93094d178da3ce0abc47da5d REVIEW: 126414 
REVIEW: 126414
Don't warn when SVG(Z) icons are provided with multiple sizes/level of detail 2015-11-30T17:01:49+00:00 Jaroslaw Staniek staniek@kde.org 2015-11-29T20:49:38+00:00 18243570bcae0cf02a4a87eff2f1834500ae955d This technically works and is practiced, e.g. for some Breeze icons. Some SVG icons do not scale well down from 32 to 22 or up from 16 to 22. For such cases icons are typically specially crafted for 22 and 16, at least. Then there's no single icon that be marked as "sc". So warnings such as: CMake Warning at ..../ECMInstallIcons.cmake:272 (message): Fixed-size icon foo.svg is not PNG or MNG ... are misleading. This change adds SVG(Z) extensions to the list of allowed icons for specific sizes. REVIEW:126199 
This technically works and is practiced, e.g. for some Breeze icons.

Some SVG icons do not scale well down from 32 to 22 or up from 16 to 22.
For such cases icons are typically specially crafted for 22 and 16, at least.
Then there's no single icon that be marked as "sc".

So warnings such as:

CMake Warning at ..../ECMInstallIcons.cmake:272 (message):
  Fixed-size icon foo.svg is not PNG or MNG

... are misleading.

This change adds SVG(Z) extensions to the list of allowed icons for specific sizes.

REVIEW:126199
Make sure we load translations on the main thread. 2015-11-30T14:07:07+00:00 Alex Merry alex.merry@kde.org 2015-11-08T23:10:59+00:00 fb4d91996affdbcd3ffc19c7646fbf77b96bf1e5 Because the old implementation (accidentally) worked when you put the ecm_create_qm_loader call in a different CMakeLists.txt file to the target the file was added to, some projects did this. This won't work with build-time-generated files, though, like moc files. So we (ab)use QTimer events to make the loading happen on the main thread. BUG: 346188 REVIEW: 126000 
Because the old implementation (accidentally) worked when you put the
ecm_create_qm_loader call in a different CMakeLists.txt file to the
target the file was added to, some projects did this.

This won't work with build-time-generated files, though, like moc files.
So we (ab)use QTimer events to make the loading happen on the main
thread.

BUG: 346188
REVIEW: 126000