extra-cmake-modules.git/modules, branch v5.12.0-rc1 hurd extra-cmake-modules.git Improve error reporting of query_qmake macro 2015-06-23T20:54:11+00:00 Aleix Pol aleixpol@kde.org 2015-06-23T20:54:11+00:00 51fb1c07bd9e6fcbb4204feb817fe94451593133 In case it fails, offer an error message and the attempted call, to make sure we can react accordingly. Note that the proper error argument is FATAL_ERROR, not FATAL. REVIEW: 124106 
In case it fails, offer an error message and the attempted call, to make
sure we can react accordingly.
Note that the proper error argument is FATAL_ERROR, not FATAL.

REVIEW: 124106
Add arguments to ecm_add_tests for listing added tests. 2015-05-18T19:21:11+00:00 Alex Merry alex.merry@kde.org 2015-05-18T18:12:06+00:00 be390dcc4d77d7faa95d040b1a346ac3c0405eac This makes it convenient to make further modifications to the tests, such as setting properties on either the tests or the targets. CHANGELOG: New arguments for ecm_add_tests(). BUG: 345797 REVIEW: 123841 
This makes it convenient to make further modifications to the tests,
such as setting properties on either the tests or the targets.

CHANGELOG: New arguments for ecm_add_tests().
BUG: 345797
REVIEW: 123841
Rework ECMAddTests documentation to emphasis ecm_add_tests(). 2015-05-18T19:20:59+00:00 Alex Merry alex.merry@kde.org 2015-05-18T10:30:10+00:00 9f96174b61fbc1145fda4cfba573361a0aa8746d ecm_add_test is the less useful (and less used) version of the functions (because you really might as well just use add_executable() and add_test() manually in that case). REVIEW: 123841 
ecm_add_test is the less useful (and less used) version of the functions
(because you really might as well just use add_executable() and
add_test() manually in that case).

REVIEW: 123841
Revert "Add PROPERTIES argument to ecm_add_test and ecm_add_tests." 2015-05-16T13:09:36+00:00 Alex Merry alex.merry@kde.org 2015-05-16T13:06:34+00:00 70b13693478b296b8a3cd1654baa8013434358c5 This reverts commit 0c224194ea7f12eaed32af746fc9138537f1919c. Stephen Kelly pointed out that this is probably not the best approach to the problem, and runs counter to the direction KDE's CMake code has been going (splitting functions up and using CMake built-ins where possible). I have a better solution in mind, which I'll post a review for later. CCMAIL: kde-buildsystem@kde.org CCBUG: 345797 
This reverts commit 0c224194ea7f12eaed32af746fc9138537f1919c.

Stephen Kelly pointed out that this is probably not the best approach to
the problem, and runs counter to the direction KDE's CMake code has been
going (splitting functions up and using CMake built-ins where possible).

I have a better solution in mind, which I'll post a review for later.

CCMAIL: kde-buildsystem@kde.org
CCBUG: 345797
Add PROPERTIES argument to ecm_add_test and ecm_add_tests. 2015-05-13T18:22:25+00:00 Alex Merry alex.merry@kde.org 2015-05-11T12:56:28+00:00 0c224194ea7f12eaed32af746fc9138537f1919c This is particularly useful with ecm_add_tests, where you may want to force a suite of tests to run in serial, or alter the timeout for multiple tests at once. BUG: 345797 REVIEW: 123722 
This is particularly useful with ecm_add_tests, where you may want to
force a suite of tests to run in serial, or alter the timeout for
multiple tests at once.

BUG: 345797
REVIEW: 123722
Add unit tests for ECMAddTests module. 2015-05-13T18:22:15+00:00 Alex Merry alex.merry@kde.org 2015-05-11T12:56:28+00:00 1b636b43d2bf4dca0332a2e2b36affa67fbe1e0b REVIEW: 123722 
REVIEW: 123722
Do not call lrelease with -compress 2015-04-09T12:36:43+00:00 Lasse Liehu lasse.liehu@gmail.com 2015-04-09T12:36:43+00:00 90db6547801ec0f637799117ac494ca503f39362 According to Oswald Buddenhagen "it doesn't buy much, and there are some long-standing issues with it". Qt bug report: https://bugreports.qt.io/browse/QTBUG-44362 REVIEW: 122501 
According to Oswald Buddenhagen "it doesn't buy much, and there are
some long-standing issues with it".

Qt bug report: https://bugreports.qt.io/browse/QTBUG-44362

REVIEW: 122501
Warn about icon filenames with leading characters. 2015-03-15T18:39:48+00:00 Alex Merry alex.merry@kde.org 2015-03-14T12:44:49+00:00 19353c9857d1e26c6508c2fc7dd530e6ee0ef316 Through a quirk of implementation, old-style icon filenames are accepted by the new-style ecm_install_icons function. It's too late to change it now, as that would break existing projects, but we can warn about it. REVIEW: 122941 
Through a quirk of implementation, old-style icon filenames are accepted
by the new-style ecm_install_icons function. It's too late to change it
now, as that would break existing projects, but we can warn about it.

REVIEW: 122941
Use lconvert path from Qt cmake config when on Qt >= 5.3.1 2015-03-06T11:14:56+00:00 Dmitry Shachnev mitya57@gmail.com 2015-03-06T11:13:38+00:00 bc27ee561756cb6e1e51e3589addab8656fd4b03 Qt5LinguistToolsConfig.cmake defines CMake target for lconvert since Qt 5.3.1, so we should use that if it is available. Our own hacks were not working in some configurations (i.e. when there is /usr/bin/lconvert managed by qtchooser, but no qtchooser configuration file). REVIEW: 122626 
Qt5LinguistToolsConfig.cmake defines CMake target for lconvert since Qt 5.3.1,
so we should use that if it is available.

Our own hacks were not working in some configurations (i.e. when there is
/usr/bin/lconvert managed by qtchooser, but no qtchooser configuration file).

REVIEW: 122626
Improve ECMPackageConfigHelpers documentation. 2015-02-28T10:37:45+00:00 Alex Merry alex.merry@kde.org 2015-02-28T10:37:45+00:00 0466f8f95e214d91b17ef078be221c6d0025e466 In particular, strongly recommend looking at the equivalent CMake documentation with regard to PATH_VARS, as a lot of projects that should be making use of it are not. 
In particular, strongly recommend looking at the equivalent CMake
documentation with regard to PATH_VARS, as a lot of projects that should
be making use of it are not.