<feed xmlns='http://www.w3.org/2005/Atom'>
<title>extra-cmake-modules.git/modules/ECMDBusAddActivationService.cmake, branch v5.94.0-rc1</title>
<subtitle>hurd extra-cmake-modules.git</subtitle>
<link rel='alternate' type='text/html' href='https://netuse.dynamicmalloc.com/cgit/extra-cmake-modules.git/'/>
<entry>
<title>Remove ECMDBusAddActivationService module</title>
<updated>2014-04-25T10:07:26+00:00</updated>
<author>
<name>Alex Merry</name>
<email>alex.merry@kde.org</email>
</author>
<published>2014-04-16T10:06:17+00:00</published>
<link rel='alternate' type='text/html' href='https://netuse.dynamicmalloc.com/cgit/extra-cmake-modules.git/commit/?id=0fd08930a4f70a0a696d19eac309f0cb0087dcf6'/>
<id>0fd08930a4f70a0a696d19eac309f0cb0087dcf6</id>
<content type='text'>
ecm_dbus_add_activation_service() requires suffient knowledge of its
internals to use that replacing two lines with one seems silly.

In order to use it you have to know it behaves like configure_file()
(because you have to construct the file yourself), except that it also
installs it somewhere (for which you have to make sure
DBUS_SERVICES_INSTALL_DIR is defined before you use it, which is
certainly not a given for non-KDE projects). By this point, why not just
use configure_file() and install()? The DBUS_SERVICES_INSTALL_DIR
provided by KDEInstallDirs is all the magic you actually need, and if
that's explicit in the CMakeLists.txt file, it's a lot more obvious that
you should have it defined somewhere.

REVIEW: 117581
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
ecm_dbus_add_activation_service() requires suffient knowledge of its
internals to use that replacing two lines with one seems silly.

In order to use it you have to know it behaves like configure_file()
(because you have to construct the file yourself), except that it also
installs it somewhere (for which you have to make sure
DBUS_SERVICES_INSTALL_DIR is defined before you use it, which is
certainly not a given for non-KDE projects). By this point, why not just
use configure_file() and install()? The DBUS_SERVICES_INSTALL_DIR
provided by KDEInstallDirs is all the magic you actually need, and if
that's explicit in the CMakeLists.txt file, it's a lot more obvious that
you should have it defined somewhere.

REVIEW: 117581
</pre>
</div>
</content>
</entry>
<entry>
<title>Add documentation generation using Sphinx</title>
<updated>2014-04-11T20:12:58+00:00</updated>
<author>
<name>Alex Merry</name>
<email>alex.merry@kde.org</email>
</author>
<published>2014-04-10T20:38:09+00:00</published>
<link rel='alternate' type='text/html' href='https://netuse.dynamicmalloc.com/cgit/extra-cmake-modules.git/commit/?id=c20d22c951e61a06701f6c2201add7c11915e7c5'/>
<id>c20d22c951e61a06701f6c2201add7c11915e7c5</id>
<content type='text'>
This is deliberately modelled very closely on CMake's documentation
system.  It's a hefty patch, because it involved changing all the
documentation to be in reStructuredText format.  I also cleaned up the
copyright/license statements at the same time.

Note that the find modules contain the full license, due to the fact
that ecm_use_find_module() copies them out of the ECM distribution.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This is deliberately modelled very closely on CMake's documentation
system.  It's a hefty patch, because it involved changing all the
documentation to be in reStructuredText format.  I also cleaned up the
copyright/license statements at the same time.

Note that the find modules contain the full license, due to the fact
that ecm_use_find_module() copies them out of the ECM distribution.
</pre>
</div>
</content>
</entry>
<entry>
<title>Rename file and macro for consistency, as requested by Alexander.</title>
<updated>2012-10-31T17:24:32+00:00</updated>
<author>
<name>David Faure</name>
<email>faure@kde.org</email>
</author>
<published>2012-10-31T17:22:22+00:00</published>
<link rel='alternate' type='text/html' href='https://netuse.dynamicmalloc.com/cgit/extra-cmake-modules.git/commit/?id=9d8174f0777647285c72e0c4da2a75ac9a58e750'/>
<id>9d8174f0777647285c72e0c4da2a75ac9a58e750</id>
<content type='text'>
"Can you please rename it to ECMDBusAddActivationService.cmake and
the contained macro to ecm_dbus_add_activation_service(), so it follows the
naming conventions in cmake (macro has the same name as the file) and ecm (all
macros have the prefix ecm)." -&gt; Done.
Nothing to adapt in kdelibs-frameworks yet, it has its own copy for now
(I'll get rid of it at the next ECM version upgrade).
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
"Can you please rename it to ECMDBusAddActivationService.cmake and
the contained macro to ecm_dbus_add_activation_service(), so it follows the
naming conventions in cmake (macro has the same name as the file) and ecm (all
macros have the prefix ecm)." -&gt; Done.
Nothing to adapt in kdelibs-frameworks yet, it has its own copy for now
(I'll get rid of it at the next ECM version upgrade).
</pre>
</div>
</content>
</entry>
</feed>
