extra-cmake-modules.git/kde-modules, branch v5.97.0-rc1

kde-modules/KDEGitCommitHooks.cmake - handle non-toplevel project

2022-07-15T14:05:38+00:00

Only install pre-commit hooks if KDE_CONFIGURE_GIT_PRE_COMMIT_HOOK
is called frm CMAKE_CURRENT_PROEJECT, eg. don't install pre-commit
hooks if ECM is inside a submodule or fetched-content.

ECMDeprecationSettings: enable warnings by default

2022-06-25T13:30:06+00:00

The main target consumers of this macro currently (should) want to be
informed about new deprecations as early as possible. As do the authors
of the warnings.

So instead let's make no warnings an opt-in. Not documenting the
now deprecated flag in the docs, given no wide-spread use yet, just
supporting still in the code with a note to users.

Document addition of -Werror=undef

2022-06-15T14:45:57+00:00

Change -Wundef warning to an error

2022-06-15T11:37:02+00:00

This should catch undefined preprocessor expressions, i.e. instead of
showing a warning if FOO_BAR_H is undefined:
 #if FOO_BAR_H

make the build fai lwith an error instead.

This combined with using #cmakedefine01 (instead of #cmakedefine), could
catch things like:
https://invent.kde.org/pim/kdepim-runtime/-/commit/05a0e5bbfbb06ed6aa88640f25f563cf7e5b1330

API dox: turn some more verbal "Note" into full note sections

2022-06-12T16:27:40+00:00

Should help readers being aware of pitfalls

NO_CHANGELOG

API dox: fix sphinx warning about Title underline too short

2022-06-12T16:27:40+00:00

NO_CHANGELOG

API dox: use more markup for code or commandline samples

2022-06-12T16:27:40+00:00

NO_CHANGELOG

API dox: improve linking to other modules referenced in text

2022-06-12T14:00:55+00:00

NO_CHANGELOG

fix linking on OpenBSD

2022-06-06T22:37:42+00:00

OpenBSD has a similar patch inside the ports, see

Allow KDE5 libraries to be built without having to link to libc explicitly.
Index: kde-modules/KDECompilerSettings.cmake
--- kde-modules/KDECompilerSettings.cmake.orig
+++ kde-modules/KDECompilerSettings.cmake
@@ -530,6 +530,8 @@ endfunction()
 # Better diagnostics (warnings, errors)
 ############################################################

+set(ALLOW_UNDEFINED_LIB_SYMBOLS No CACHE BOOL "allow undefined symbols in generated shared objects")
+
 if ((CMAKE_CXX_COMPILER_ID STREQUAL "GNU" AND NOT APPLE) OR
         (CMAKE_CXX_COMPILER_ID MATCHES "Clang" AND NOT APPLE) OR
         (CMAKE_CXX_COMPILER_ID STREQUAL "Intel" AND NOT WIN32))
@@ -537,9 +539,11 @@ if ((CMAKE_CXX_COMPILER_ID STREQUAL "GNU" AND NOT APPL
     set(CMAKE_SHARED_LINKER_FLAGS "-Wl,--fatal-warnings ${CMAKE_SHARED_LINKER_FLAGS}")
     set(CMAKE_MODULE_LINKER_FLAGS "-Wl,--fatal-warnings ${CMAKE_MODULE_LINKER_FLAGS}")

-    # Do not allow undefined symbols, even in non-symbolic shared libraries
-    set(CMAKE_SHARED_LINKER_FLAGS "-Wl,--no-undefined ${CMAKE_SHARED_LINKER_FLAGS}")
-    set(CMAKE_MODULE_LINKER_FLAGS "-Wl,--no-undefined ${CMAKE_MODULE_LINKER_FLAGS}")
+    if (NOT ${ALLOW_UNDEFINED_LIB_SYMBOLS})
+        # Do not allow undefined symbols, even in non-symbolic shared libraries
+        set(CMAKE_SHARED_LINKER_FLAGS "-Wl,--no-undefined ${CMAKE_SHARED_LINKER_FLAGS}")
+        set(CMAKE_MODULE_LINKER_FLAGS "-Wl,--no-undefined ${CMAKE_MODULE_LINKER_FLAGS}")
+    endif()
 endif()

 set(_KDE_GCC_COMMON_WARNING_FLAGS "-Wall -Wextra -Wcast-align -Wchar-subscripts -Wformat-security -Wno-long-long -Wpointer-arith -Wundef")

KDEGitCommitHooks: Check if KDEClangFormat was included

2022-05-30T15:24:13+00:00

If the module is not included, the current message would be misleading.

Including the module by default is undesirable, because we print out a warning
that we do not override an existing module. While this warning is reasonable in most
cases, it is annoying for projects that have a custom clang-format file.

Checking if a .clang-format file exists and if not including KDEClangFormat is fragile,
because it depends on the include order of the modules.

Considering all that, a proper warning with instructions on how to fix the issue
is IMHO the best way to go.