<feed xmlns='http://www.w3.org/2005/Atom'>
<title>extra-cmake-modules.git/kde-modules, branch v5.95.0-rc1</title>
<subtitle>hurd extra-cmake-modules.git</subtitle>
<link rel='alternate' type='text/html' href='https://netuse.dynamicmalloc.com/cgit/extra-cmake-modules.git/'/>
<entry>
<title>fix linking on OpenBSD</title>
<updated>2022-06-06T22:37:42+00:00</updated>
<author>
<name>Christoph Cullmann</name>
<email>cullmann@kde.org</email>
</author>
<published>2022-05-20T17:21:21+00:00</published>
<link rel='alternate' type='text/html' href='https://netuse.dynamicmalloc.com/cgit/extra-cmake-modules.git/commit/?id=b01c2150b09ba50de34e08d2d5ccf53359905b5f'/>
<id>b01c2150b09ba50de34e08d2d5ccf53359905b5f</id>
<content type='text'>
OpenBSD has a similar patch inside the ports, see

Allow KDE5 libraries to be built without having to link to libc explicitly.
Index: kde-modules/KDECompilerSettings.cmake
--- kde-modules/KDECompilerSettings.cmake.orig
+++ kde-modules/KDECompilerSettings.cmake
@@ -530,6 +530,8 @@ endfunction()
 # Better diagnostics (warnings, errors)
 ############################################################

+set(ALLOW_UNDEFINED_LIB_SYMBOLS No CACHE BOOL "allow undefined symbols in generated shared objects")
+
 if ((CMAKE_CXX_COMPILER_ID STREQUAL "GNU" AND NOT APPLE) OR
         (CMAKE_CXX_COMPILER_ID MATCHES "Clang" AND NOT APPLE) OR
         (CMAKE_CXX_COMPILER_ID STREQUAL "Intel" AND NOT WIN32))
@@ -537,9 +539,11 @@ if ((CMAKE_CXX_COMPILER_ID STREQUAL "GNU" AND NOT APPL
     set(CMAKE_SHARED_LINKER_FLAGS "-Wl,--fatal-warnings ${CMAKE_SHARED_LINKER_FLAGS}")
     set(CMAKE_MODULE_LINKER_FLAGS "-Wl,--fatal-warnings ${CMAKE_MODULE_LINKER_FLAGS}")

-    # Do not allow undefined symbols, even in non-symbolic shared libraries
-    set(CMAKE_SHARED_LINKER_FLAGS "-Wl,--no-undefined ${CMAKE_SHARED_LINKER_FLAGS}")
-    set(CMAKE_MODULE_LINKER_FLAGS "-Wl,--no-undefined ${CMAKE_MODULE_LINKER_FLAGS}")
+    if (NOT ${ALLOW_UNDEFINED_LIB_SYMBOLS})
+        # Do not allow undefined symbols, even in non-symbolic shared libraries
+        set(CMAKE_SHARED_LINKER_FLAGS "-Wl,--no-undefined ${CMAKE_SHARED_LINKER_FLAGS}")
+        set(CMAKE_MODULE_LINKER_FLAGS "-Wl,--no-undefined ${CMAKE_MODULE_LINKER_FLAGS}")
+    endif()
 endif()

 set(_KDE_GCC_COMMON_WARNING_FLAGS "-Wall -Wextra -Wcast-align -Wchar-subscripts -Wformat-security -Wno-long-long -Wpointer-arith -Wundef")
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
OpenBSD has a similar patch inside the ports, see

Allow KDE5 libraries to be built without having to link to libc explicitly.
Index: kde-modules/KDECompilerSettings.cmake
--- kde-modules/KDECompilerSettings.cmake.orig
+++ kde-modules/KDECompilerSettings.cmake
@@ -530,6 +530,8 @@ endfunction()
 # Better diagnostics (warnings, errors)
 ############################################################

+set(ALLOW_UNDEFINED_LIB_SYMBOLS No CACHE BOOL "allow undefined symbols in generated shared objects")
+
 if ((CMAKE_CXX_COMPILER_ID STREQUAL "GNU" AND NOT APPLE) OR
         (CMAKE_CXX_COMPILER_ID MATCHES "Clang" AND NOT APPLE) OR
         (CMAKE_CXX_COMPILER_ID STREQUAL "Intel" AND NOT WIN32))
@@ -537,9 +539,11 @@ if ((CMAKE_CXX_COMPILER_ID STREQUAL "GNU" AND NOT APPL
     set(CMAKE_SHARED_LINKER_FLAGS "-Wl,--fatal-warnings ${CMAKE_SHARED_LINKER_FLAGS}")
     set(CMAKE_MODULE_LINKER_FLAGS "-Wl,--fatal-warnings ${CMAKE_MODULE_LINKER_FLAGS}")

-    # Do not allow undefined symbols, even in non-symbolic shared libraries
-    set(CMAKE_SHARED_LINKER_FLAGS "-Wl,--no-undefined ${CMAKE_SHARED_LINKER_FLAGS}")
-    set(CMAKE_MODULE_LINKER_FLAGS "-Wl,--no-undefined ${CMAKE_MODULE_LINKER_FLAGS}")
+    if (NOT ${ALLOW_UNDEFINED_LIB_SYMBOLS})
+        # Do not allow undefined symbols, even in non-symbolic shared libraries
+        set(CMAKE_SHARED_LINKER_FLAGS "-Wl,--no-undefined ${CMAKE_SHARED_LINKER_FLAGS}")
+        set(CMAKE_MODULE_LINKER_FLAGS "-Wl,--no-undefined ${CMAKE_MODULE_LINKER_FLAGS}")
+    endif()
 endif()

 set(_KDE_GCC_COMMON_WARNING_FLAGS "-Wall -Wextra -Wcast-align -Wchar-subscripts -Wformat-security -Wno-long-long -Wpointer-arith -Wundef")
</pre>
</div>
</content>
</entry>
<entry>
<title>KDEGitCommitHooks: Check if KDEClangFormat was included</title>
<updated>2022-05-30T15:24:13+00:00</updated>
<author>
<name>Alexander Lohnau</name>
<email>alexander.lohnau@gmx.de</email>
</author>
<published>2022-04-30T06:57:26+00:00</published>
<link rel='alternate' type='text/html' href='https://netuse.dynamicmalloc.com/cgit/extra-cmake-modules.git/commit/?id=79caa00d0949138b237ecced794a903237bcf2b5'/>
<id>79caa00d0949138b237ecced794a903237bcf2b5</id>
<content type='text'>
If the module is not included, the current message would be misleading.

Including the module by default is undesirable, because we print out a warning
that we do not override an existing module. While this warning is reasonable in most
cases, it is annoying for projects that have a custom clang-format file.

Checking if a .clang-format file exists and if not including KDEClangFormat is fragile,
because it depends on the include order of the modules.

Considering all that, a proper warning with instructions on how to fix the issue
is IMHO the best way to go.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
If the module is not included, the current message would be misleading.

Including the module by default is undesirable, because we print out a warning
that we do not override an existing module. While this warning is reasonable in most
cases, it is annoying for projects that have a custom clang-format file.

Checking if a .clang-format file exists and if not including KDEClangFormat is fragile,
because it depends on the include order of the modules.

Considering all that, a proper warning with instructions on how to fix the issue
is IMHO the best way to go.
</pre>
</div>
</content>
</entry>
<entry>
<title>KDEGitCommitHooks: Fix quoting of variables</title>
<updated>2022-05-10T08:15:49+00:00</updated>
<author>
<name>Alex Richardson</name>
<email>Alexander.Richardson@cl.cam.ac.uk</email>
</author>
<published>2022-05-10T08:15:49+00:00</published>
<link rel='alternate' type='text/html' href='https://netuse.dynamicmalloc.com/cgit/extra-cmake-modules.git/commit/?id=e1ce82070087fdbb93411e12732d5dd72d97722e'/>
<id>e1ce82070087fdbb93411e12732d5dd72d97722e</id>
<content type='text'>
I was getting CMake errors in repositories that had a pre-existing commit
hook: `string sub-command FIND requires 3 or 4 parameters.`
Adding quotes around the variables from 6224e7b8c28d434b81a19ac47b88cb58fee9d7d5
fixes this issue for me.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
I was getting CMake errors in repositories that had a pre-existing commit
hook: `string sub-command FIND requires 3 or 4 parameters.`
Adding quotes around the variables from 6224e7b8c28d434b81a19ac47b88cb58fee9d7d5
fixes this issue for me.
</pre>
</div>
</content>
</entry>
<entry>
<title>KDEGitCommitHooks: don't overwrite git pre-commit hook script</title>
<updated>2022-04-10T14:32:10+00:00</updated>
<author>
<name>Ahmad Samir</name>
<email>a.samirh78@gmail.com</email>
</author>
<published>2022-04-10T11:56:35+00:00</published>
<link rel='alternate' type='text/html' href='https://netuse.dynamicmalloc.com/cgit/extra-cmake-modules.git/commit/?id=6224e7b8c28d434b81a19ac47b88cb58fee9d7d5'/>
<id>6224e7b8c28d434b81a19ac47b88cb58fee9d7d5</id>
<content type='text'>
If the .git/hooks/pre-commit already exists, only add the clang-format line
if it doesn't already exist.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
If the .git/hooks/pre-commit already exists, only add the clang-format line
if it doesn't already exist.
</pre>
</div>
</content>
</entry>
<entry>
<title>KDEGitCommitHooks: only configure pre-commit hook if needed</title>
<updated>2022-04-10T14:31:51+00:00</updated>
<author>
<name>Ahmad Samir</name>
<email>a.samirh78@gmail.com</email>
</author>
<published>2022-04-10T04:22:49+00:00</published>
<link rel='alternate' type='text/html' href='https://netuse.dynamicmalloc.com/cgit/extra-cmake-modules.git/commit/?id=d0f58e8beafe4ffd4bd371152947b84ebe8a8ef2'/>
<id>d0f58e8beafe4ffd4bd371152947b84ebe8a8ef2</id>
<content type='text'>
If clang-format isn't found, there is nothing to write to the file.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
If clang-format isn't found, there is nothing to write to the file.
</pre>
</div>
</content>
</entry>
<entry>
<title>KDEInstallDirs6: port from custom logic to ecm_query_qt</title>
<updated>2022-03-24T16:24:38+00:00</updated>
<author>
<name>Ahmad Samir</name>
<email>a.samirh78@gmail.com</email>
</author>
<published>2022-03-20T11:03:24+00:00</published>
<link rel='alternate' type='text/html' href='https://netuse.dynamicmalloc.com/cgit/extra-cmake-modules.git/commit/?id=55296264560182d7b0170cd6b7d0cc5bca79dd9f'/>
<id>55296264560182d7b0170cd6b7d0cc5bca79dd9f</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Port from ECMQueryQmake to ECMQueryQt</title>
<updated>2022-03-24T16:24:38+00:00</updated>
<author>
<name>Ahmad Samir</name>
<email>a.samirh78@gmail.com</email>
</author>
<published>2022-03-20T10:57:52+00:00</published>
<link rel='alternate' type='text/html' href='https://netuse.dynamicmalloc.com/cgit/extra-cmake-modules.git/commit/?id=a720a6380ca75ec23e0635cc8ae47ee4b9508be0'/>
<id>a720a6380ca75ec23e0635cc8ae47ee4b9508be0</id>
<content type='text'>
Continuation of commit 4e47b053c9d799.

All unittests still pass.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Continuation of commit 4e47b053c9d799.

All unittests still pass.
</pre>
</div>
</content>
</entry>
<entry>
<title>Fix clang-format git hook script</title>
<updated>2022-03-21T11:07:36+00:00</updated>
<author>
<name>Ahmad Samir</name>
<email>a.samirh78@gmail.com</email>
</author>
<published>2022-03-18T13:40:59+00:00</published>
<link rel='alternate' type='text/html' href='https://netuse.dynamicmalloc.com/cgit/extra-cmake-modules.git/commit/?id=da4ab76d01012f74d91d59b59c3366f3654a5b33'/>
<id>da4ab76d01012f74d91d59b59c3366f3654a5b33</id>
<content type='text'>
It should be --extensions "cpp,h,hpp,c"; previously, I naively tested that
it didn't bother .json files, but I not if it'll actually trigger for e.g.
a .h file...
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
It should be --extensions "cpp,h,hpp,c"; previously, I naively tested that
it didn't bother .json files, but I not if it'll actually trigger for e.g.
a .h file...
</pre>
</div>
</content>
</entry>
<entry>
<title>KDEClangFormat: se the same source file extensions in clang-format script and target</title>
<updated>2022-03-17T10:57:00+00:00</updated>
<author>
<name>Ahmad Samir</name>
<email>a.samirh78@gmail.com</email>
</author>
<published>2022-03-17T10:57:00+00:00</published>
<link rel='alternate' type='text/html' href='https://netuse.dynamicmalloc.com/cgit/extra-cmake-modules.git/commit/?id=7cb3191ccb1dc24ff21a9e41ec30d52f420c98e6'/>
<id>7cb3191ccb1dc24ff21a9e41ec30d52f420c98e6</id>
<content type='text'>
Previously the clang-format.sh git hook script didn't specify the file
extensions to format; however it looks like with recent(?) clang-format
versions 'git clang-format' will consider .json files if such files were
changed by a commit, which makes the script fail, see:
https://invent.kde.org/frameworks/extra-cmake-modules/-/merge_requests/254

Sepcify the file extensions by passing --extensions to 'git clang-format'
command.

Also add ".hpp" to the file extensions we format, and use the same list of
file extensions everywhere.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Previously the clang-format.sh git hook script didn't specify the file
extensions to format; however it looks like with recent(?) clang-format
versions 'git clang-format' will consider .json files if such files were
changed by a commit, which makes the script fail, see:
https://invent.kde.org/frameworks/extra-cmake-modules/-/merge_requests/254

Sepcify the file extensions by passing --extensions to 'git clang-format'
command.

Also add ".hpp" to the file extensions we format, and use the same list of
file extensions everywhere.
</pre>
</div>
</content>
</entry>
<entry>
<title>Fix checking the repository name for detached remotes</title>
<updated>2022-03-12T01:13:44+00:00</updated>
<author>
<name>Aleix Pol</name>
<email>aleixpol@kde.org</email>
</author>
<published>2022-03-12T01:13:44+00:00</published>
<link rel='alternate' type='text/html' href='https://netuse.dynamicmalloc.com/cgit/extra-cmake-modules.git/commit/?id=56276c5ebe66c5431b7c1c6aa6a328ce7ed25a32'/>
<id>56276c5ebe66c5431b7c1c6aa6a328ce7ed25a32</id>
<content type='text'>
If we are not tracking a specific branch, assume the remote is "origin"
which is git's default.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
If we are not tracking a specific branch, assume the remote is "origin"
which is git's default.
</pre>
</div>
</content>
</entry>
</feed>
