extra-cmake-modules.git/kde-modules, branch v5.91.0 hurd extra-cmake-modules.git Make clang-format Git hook work in worktrees 2022-02-04T09:14:28+00:00 The Assassin theassassin@assassinate-you.net 2022-02-04T09:14:28+00:00 927eb53580377f9460b8fc10cf3c561a31bde689 Otherwise, commits will be rejected because the hook cannot be found from the workdir root dir (there is only one .git directory in a checkout, but commands are run relative to the worktree root dir). 

Otherwise, commits will be rejected because the hook cannot be found from the workdir root dir (there is only one .git directory in a checkout, but commands are run relative to the worktree root dir).
 kde_package_app_templates: drop atime,ctime, consistently set mtime 2022-02-01T18:29:08+00:00 Emil Velikov emil.l.velikov@gmail.com 2022-02-01T14:01:32+00:00 48313bf31d92cfff175452101c787705e08c6560 As outlined in https://reproducible-builds.org/docs/archives/ to ensure that tarballs are reproducible, one should honour SOURCE_DATE_EPOCH. In the case it's not, fallback to date +%s, set the mtime. Delete atime and ctime completely. No idea if this is better or worse. Based on the patch by: Brendan Tildesley <mail@brendan.scot> From: https://bugs.kde.org/show_bug.cgi?id=443532 v2: Emil - Split from larger patch - Fallback to date +%s v3: Emil - $ENV{...} to evaluate the variable Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com> 
As outlined in https://reproducible-builds.org/docs/archives/ to ensure
that tarballs are reproducible, one should honour SOURCE_DATE_EPOCH.

In the case it's not, fallback to date +%s, set the mtime.

Delete atime and ctime completely. No idea if this is better or worse.

Based on the patch by: Brendan Tildesley <mail@brendan.scot>
From: https://bugs.kde.org/show_bug.cgi?id=443532

v2: Emil
 - Split from larger patch
 - Fallback to date +%s

v3: Emil
 - $ENV{...} to evaluate the variable

Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com>
kde_package_app_templates: use numeric owner/group with tar 2022-02-01T14:36:31+00:00 Emil Velikov emil.l.velikov@gmail.com 2022-02-01T13:47:38+00:00 2ca1750158dbd2058680b7e315ac76746e30fd0f In some build environments like in Guix, the GID of "root" is not consistent. With --numeric-owner, we only need to specify UID and GID, the user name is unneeded, so set --owner=0 --group=0 Based on the patch by: Brendan Tildesley <mail@brendan.scot> From: https://bugs.kde.org/show_bug.cgi?id=443532 v2: Emil - Keep args reorder a separate commit - Move time changes into separate commit Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com> 
In some build environments like in Guix, the GID of "root" is not
consistent.

With --numeric-owner, we only need to specify UID and GID, the user name
is unneeded, so set --owner=0 --group=0

Based on the patch by: Brendan Tildesley <mail@brendan.scot>
From: https://bugs.kde.org/show_bug.cgi?id=443532

v2: Emil
 - Keep args reorder a separate commit
 - Move time changes into separate commit

Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com>
kde_package_app_templates: reorder and spli tar args 2022-02-01T14:36:31+00:00 Emil Velikov emil.l.velikov@gmail.com 2022-02-01T13:44:41+00:00 4573cd2fca63acf5cdc3c6bbf1cf033c16835bd4 Split the arguments in separate lines, grouped appropriately. No functional changes. Suggested-by: @adridg Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com> 
Split the arguments in separate lines, grouped appropriately.
No functional changes.

Suggested-by: @adridg
Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com>
Adapt KDEInstallDirs unit test to consider the new version-less variables 2022-01-25T09:05:16+00:00 Volker Krause vkrause@kde.org 2022-01-23T16:35:40+00:00 b25b7df554da25889f7839ac09d8051e018d1e59 Fixes unit tests with Qt6 and identified the missing definition of the full path variables for aliases. 
Fixes unit tests with Qt6 and identified the missing definition of the
full path variables for aliases.
Only enable -bsymbolic-functions when Qt is built in a compatible way 2022-01-20T15:57:43+00:00 Volker Krause vkrause@kde.org 2022-01-08T11:45:07+00:00 120bb5f644bbcdcb7197d476dc70587d3a3e4b2a With Qt6 that isn't always the case, for example in our Linux CI image. Using -bsymbolic-function on the final executable in that case can result in function pointer conntect or method/signal lookups to fail. This can be observed in various unit test failures on the CI right now. 
With Qt6 that isn't always the case, for example in our Linux CI image.
Using -bsymbolic-function on the final executable in that case can result
in function pointer conntect or method/signal lookups to fail. This can be
observed in various unit test failures on the CI right now.
Rename KDEDeprecationSettings to ECMDeprecationSettings 2022-01-09T19:23:30+00:00 Alexander Lohnau alexander.lohnau@gmx.de 2022-01-09T19:22:30+00:00 2ce35e24ba218ed5e79b2d70f4589e408e01db5c Semantically this is an ECM module, because it can be used to manage deprecated Qt API and from any project which use ecm_generate_export_headers 
Semantically this is an ECM module, because it can be used to manage deprecated
Qt API and from any project which use ecm_generate_export_headers
Add ecm_set_deprecation_versions cmake function 2022-01-04T17:30:26+00:00 Alexander Lohnau alexander.lohnau@gmx.de 2021-12-19T09:58:53+00:00 e858a46995b5eac3aba822fff3fd2f37b5e224cc This will make setting the deprecation versions easier, otherwise one would need to edit the hex value. It also helps to keep the required versions and deprecation versions in sync. Also this allows one to keep the deprecation warnings, when one excludes deprecations for a specific version. Additionally the deprecation version can be overwritten by a cmake parameter. This will make local testing easier, because one does not need to edit the CMakeLists.txt files. Task: https://phabricator.kde.org/T15109 
This will make setting the deprecation versions easier, otherwise one would need
to edit the hex value. It also helps to keep the required versions and deprecation versions
in sync.

Also this allows one to keep the deprecation warnings, when one excludes deprecations for a specific version.

Additionally the deprecation version can be overwritten by a cmake parameter.
This will make local testing easier, because one does not need to edit the CMakeLists.txt files.

Task: https://phabricator.kde.org/T15109
Add missing prefix to version-less install directory aliases 2021-12-18T11:18:55+00:00 Volker Krause vkrause@kde.org 2021-12-18T11:18:55+00:00 1cfcd2a36035f962a27ab0a431355f302008ad0d So far we were defining e.g. KSERVICESDIR next to KDE_INSTALL_KSERVICES5DIR here, rather than the intended KDE_INSTALL_KSERVICESDIR. 
So far we were defining e.g. KSERVICESDIR next to KDE_INSTALL_KSERVICES5DIR
here, rather than the intended KDE_INSTALL_KSERVICESDIR.
Define version-less install targets in KDEInstallDirs5.cmake 2021-12-05T00:13:05+00:00 Volker Krause vkrause@kde.org 2021-11-30T15:59:32+00:00 744494e6cdaee066064b9fecd86040e3b232a2f7 This enables forward-compatibility with KDEInstallDirs6.cmake This was partly done already, but in the wrong order and not for all versioned variables. 
This enables forward-compatibility with KDEInstallDirs6.cmake

This was partly done already, but in the wrong order and not for all
versioned variables.