This reverts commit 6684cb99bdf408fc491e547393dbd7aac4d151f2.

See https://phabricator.kde.org/D8256 for details

Summary:
The generated C++ sources include <sip.h>, so it must be available.
Check for it in the version specific directories and fall back to
the default include directories.

Test Plan:
install python2-devel and python3-devel
install one of python{x}-sip-devel

bindings should be generated for the matching python version.

Reviewers: #frameworks, arojas

Reviewed By: arojas

Subscribers: arojas, kde-frameworks-devel, kde-buildsystem

Tags: #frameworks, #build_system

Differential Revision: https://phabricator.kde.org/D14915

Summary:
In case both python 2.7 and 3 are installed, but clang python bindings
are only installed for python 3, there will be no error message but
the self check will fail.

Check for clang bindings for both python2 and python3 (if installed),
and use the first one found to generate the sip bindings files.

Note, it is possible to e.g. use python2 to generate the sip binding
files (requires clang bindings), but generate bindings for python
2, 3, or both (requires matching python-devel and python-sip-devel
packages).

Test Plan:
install python3-clang bindings
install python2-clang bindings
or one of the above

the matching python version is used to run sip_generator.py

Reviewers: #frameworks, arojas

Reviewed By: arojas

Subscribers: kde-frameworks-devel, kde-buildsystem

Tags: #frameworks, #build_system

Differential Revision: https://phabricator.kde.org/D14914

Summary:
iteritems is no longer an available method for dict in Python 3. Using
dict.items() is functionally identical, although it creates some overhead
for Python 2.7 (creation of a temporary list). As this is only called
when tracing, this is not a big issue. For Python 3, there is no
overhead (dict.items() returns an iterator).

Test Plan:
Run python3 sip_generator.py ...
Run python2 sip_generator.py ...
Both generate the same code

Reviewers: #frameworks, arojas

Reviewed By: arojas

Subscribers: arojas, kde-frameworks-devel, kde-buildsystem

Tags: #frameworks, #build_system

Differential Revision: https://phabricator.kde.org/D14912

On Windows at least this is simply broken and leads to tests failing because plugins from other modules cannot be found at all.
Based on this it is likely that it is broken on other platforms as well, it's just being hidden there by other logic.

CCMAIL: kde-frameworks-devel@kde.org

When building on non-glibc Unix platforms, such as Solaris, NetBSD, and Linux/musl or Linux/uclibc, multiple components of KF5 fail to build. This is because -std=iso9899:1990 is specified (for strict C90 compliance) but _XOPEN_SOURCE is not defined, so none of the POSIX interfaces are exported. I have seen this reported in at least:

* kinit
* kscreenlocker
* plasma-workspace

The attached patch resolves this issue on all our build boxes; additionally, applying it to my glibc builder did not change the already working result.

BUG: 373175

Differential Revision: https://phabricator.kde.org/D8256

Reviewers: apol, alexeymin

Reviewed By: alexeymin

Subscribers: alexeymin, kde-frameworks-devel, kde-buildsystem

Tags: #frameworks, #build_system

Differential Revision: https://phabricator.kde.org/D15084

Summary:
Keep the enum intact by emitting the class keyword in case the enum is
scoped.
Use the complete enum scope for parameter values, the enclosing scope is
only correct to use for unscoped enums.
The python Cursor.is_scoped_enum() method has been added with LLVM/Clang
version 5.0.

BUG: 397154

Test Plan: build kcoreaddons

Reviewers: #frameworks, mpyne

Reviewed By: mpyne

Subscribers: mpyne, kde-frameworks-devel, kde-buildsystem

Tags: #frameworks, #build_system

Differential Revision: https://phabricator.kde.org/D14908

Summary:
The canonical name is libclang.so, which seems to be available on all
distributions (RH, SUSE, Ubuntu, Debian, ...) while the symlinks with
version suffix (e.g. libclang-6.0) are specific to Debian and derivatives.
Keep the current checks, but fallback to the unversioned library name.

Test Plan:
on openSUSE TW/Leap:
run cmake
-> libclang is found

Reviewers: #frameworks, dfaure

Reviewed By: dfaure

Subscribers: kde-frameworks-devel, kde-buildsystem

Tags: #frameworks, #build_system

Differential Revision: https://phabricator.kde.org/D14909